Skip to content

Support vector SVG image imports#54

Merged
boomzero merged 2 commits into
mainfrom
codex/support-vector-svg-images
May 6, 2026
Merged

Support vector SVG image imports#54
boomzero merged 2 commits into
mainfrom
codex/support-vector-svg-images

Conversation

@boomzero

@boomzero boomzero commented May 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep newly imported SVGs as vector data URLs by normalizing root width/height instead of rasterizing to PNG
  • normalize SVGs for image add, clipboard paste, and slide background uploads
  • add SVG helper tests for UTF-8, viewBox/partial dimensions, malformed XML, MIME detection, and data URL variants

Verification

  • npm exec vitest -- run tests/renderer/lib/svg.test.ts
  • npm run typecheck
  • npm run lint
  • Manual QA passed with SVG fixtures for viewBox-only, percentage dimensions, explicit dimensions, no dims/no viewBox, non-ASCII text, script smoke, malformed SVG rejection, and background error handling

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56eb76c1fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/renderer/src/lib/svg.ts Outdated
@boomzero boomzero force-pushed the codex/support-vector-svg-images branch from 56eb76c to 6d301b6 Compare May 5, 2026 12:53
@boomzero

boomzero commented May 5, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d301b6e5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/renderer/src/lib/svg.ts
Comment thread src/renderer/src/App.svelte Outdated
@boomzero boomzero merged commit ad17772 into main May 6, 2026
7 checks passed
@boomzero boomzero deleted the codex/support-vector-svg-images branch May 6, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant