Open
Conversation
Owner
Author
|
Now that the project compiles I ran the Benchmarks for the matrix composition and they are exactly the same. Since matrix composition does not use any of the Khatri-Rao and derivatives functions it doesn't suffer any performance impact! However, just by running the Is there any way we can optimize the type safe matrix construction? |
|
@bolt12 Yes, I suspected that this implementation would be slower. One of the problems is that there is a lot of padding ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has type safe matrix construction primitives via linear maps semantics.
The new file called
Alternative.hswhen ready will substitute the one calledInternal.hs.I still need to refactor the other modules.