fix(ios): grok tucked tab returns on focus + generic diff pill when blurred#9
Merged
Merged
Conversation
…lurred Two composer-blur polish items from on-device testing of build 23. 1. Grok tucked tab didn't return on focus (all other shells did). The focus-gated above-rows group had an IMPLICIT zIndex while the composer core below carries .zIndex(tuckedTab ? 1 : 0). SwiftUI renders a conditionally- inserted sibling behind an explicit-zIndex sibling on insertion, so grok's tab (uniquely tuckedAboveTab) got eaten when it re-appeared. Give the group an explicit .zIndex(0). 2. Active-changes diff pill. When the composer is blurred AND there's an active run diff, show a compact generic "N files +X −Y" pill above the one-line composer (ComposerDiffPill — same for every shell, tap opens the diff) instead of the full composer-specific changes row. The full, shell-specific above rows still return on focus. So during active changes you always get a mini diff indicator above the collapsed composer, Codex-app-style. Verified: swift build + 73 tests + iPhone-17 simulator build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
boggspa
added a commit
that referenced
this pull request
Jun 18, 2026
…nges diff pill Build 24 = PR #9: grok composer's tucked tab returns on focus (explicit zIndex on the focus-inserted above-rows group) + a generic "N files +X −Y" diff pill above the one-line composer while blurred during active changes. iOS-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two composer-blur polish items from on-device testing of build 23.
1. Grok tucked tab now returns on focus
All other shells returned their above rows on focus; grok didn't. The focus-gated above-rows group had an implicit
zIndex, while the composer core below carries.zIndex(tuckedTab ? 1 : 0). SwiftUI renders a conditionally-inserted sibling behind an explicit-zIndex sibling on insertion — so grok's tab (the onlytuckedAboveTabshell) got eaten when it re-appeared on focus. Fix: give the group an explicit.zIndex(0)so both siblings are explicitly ordered.2. Generic diff pill when blurred + active changes
When the composer is blurred and there's an active run diff, a compact "N files +X −Y" pill (
ComposerDiffPill) now floats above the one-line composer — generic for every shell, tap opens the diff — instead of the full composer-specific changes row. The full, shell-specific above rows still return on focus. So during active changes you always get a mini diff indicator above the collapsed composer (Codex-app-style, our twist: muted "N files", green additions, red deletions, compactkcounts).Blurred-state matrix now:
Verification
swift build✓ ·swift test73/73 ✓ · iPhone-17 simulator BUILD SUCCEEDED ✓🤖 Generated with Claude Code