Skip to content

chore(compose): 精简 dev-web env · 移除冗余 LOG_DIR#61

Merged
bob798 merged 1 commit into
mainfrom
claude/performance-investigation-cXVqZ
May 26, 2026
Merged

chore(compose): 精简 dev-web env · 移除冗余 LOG_DIR#61
bob798 merged 1 commit into
mainfrom
claude/performance-investigation-cXVqZ

Conversation

@bob798

@bob798 bob798 commented May 26, 2026

Copy link
Copy Markdown
Owner

Summary

PR #60 留下的小尾巴:docker-compose.ymlLOG_DIR: /app/logs 这个 env 是冗余的——app/logger.py:20 默认 LOG_DIR="logs",配合 Dockerfile:22 WORKDIR /app 解析为 /app/logs,与挂载点完全一致。显式 env 没有效果上的差异,删掉。

Diff

       SPEAKEASY_DB_PATH: /app/data/speakeasy.db
-      # 日志落到 /app/logs(挂 named volume,宿主机可 `docker compose exec` 查看或挂主机目录持久化)
-      LOG_DIR: /app/logs
     volumes:
       - /etc/localtime:/etc/localtime:ro
       - logs:/app/logs

只动 docker-compose.yml,2 行删除,无功能变更。

Test plan

  • 本地容器跑 app/logger.py 默认值,日志仍写到 /app/logs/app.log
  • 合并后 GitHub Actions 部署成功
  • VPS 上 docker compose exec dev-web env | grep LOG 不再出现 LOG_DIR,/app/logs/app.log 正常追加

Generated by Claude Code

LOG_DIR 在 app/logger.py 默认为 "logs",配合 Dockerfile WORKDIR /app
解析为 /app/logs,与挂载点一致 → 显式 env 是冗余的,删掉。

https://claude.ai/code/session_0196zGVc7pLoNaypQLM7vodN
@bob798 bob798 merged commit 3b78bae into main May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants