chore(compose): 精简 dev-web env · 移除冗余 LOG_DIR#61
Merged
Conversation
LOG_DIR 在 app/logger.py 默认为 "logs",配合 Dockerfile WORKDIR /app 解析为 /app/logs,与挂载点一致 → 显式 env 是冗余的,删掉。 https://claude.ai/code/session_0196zGVc7pLoNaypQLM7vodN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #60 留下的小尾巴:
docker-compose.yml里LOG_DIR: /app/logs这个 env 是冗余的——app/logger.py:20默认LOG_DIR="logs",配合Dockerfile:22 WORKDIR /app解析为/app/logs,与挂载点完全一致。显式 env 没有效果上的差异,删掉。Diff
只动
docker-compose.yml,2 行删除,无功能变更。Test plan
app/logger.py默认值,日志仍写到/app/logs/app.logdocker compose exec dev-web env | grep LOG不再出现 LOG_DIR,/app/logs/app.log正常追加Generated by Claude Code