Skip to content

gRPC SSO implementation#54

Open
BOBAvov wants to merge 16 commits into
v2from
v2_vova
Open

gRPC SSO implementation#54
BOBAvov wants to merge 16 commits into
v2from
v2_vova

Conversation

@BOBAvov

@BOBAvov BOBAvov commented Dec 8, 2025

Copy link
Copy Markdown

No description provided.

@BOBAvov BOBAvov requested review from Copilot and zhikh23 and removed request for Copilot December 8, 2025 19:05
@zhikh23 zhikh23 changed the title V2 vova gRPC SSO implementation Dec 9, 2025

@zhikh23 zhikh23 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Описано в ЛС

Copilot AI review requested due to automatic review settings December 9, 2025 17:49
@BOBAvov BOBAvov requested a review from zhikh23 December 9, 2025 17:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a gRPC-based Single Sign-On (SSO) integration, replacing the mock IsAdminProvider with a real SSO service client that communicates with an external authentication service. The change enables actual admin verification through a remote gRPC service instead of using in-memory mock data.

Key Changes

  • Introduces a new SSO client (internal/infra/sso) that connects to an external authentication service via gRPC
  • Removes the mock IsAdminProvider implementation from internal/infra/mock
  • Adds SSO configuration support (host and port) to the application config

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
internal/infra/sso/is_admin_provider.go New gRPC client for SSO service authentication with IsAdmin functionality
internal/infra/mock/is_admin_provider.go Removed mock implementation that is being replaced by real SSO integration
internal/config/sso.go New configuration struct for SSO connection parameters (host and port)
internal/config/config.go Added SSO field to main Config struct
cmd/grpc/main.go Updated to use real SSO client instead of mock
tests/suite/suite.go Updated test suite to use real SSO client instead of mock
config/local.yaml Added SSO configuration with localhost:44044 as default endpoint
go.mod Updated Go version and added gRPC SSO protos dependency, upgraded gRPC to v1.76.0
go.sum Updated dependency checksums for new and upgraded packages
.golangci.yaml Modified exhaustruct exclusion pattern (contains an error)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread .golangci.yaml Outdated
Comment thread cmd/grpc/main.go Outdated
Comment thread tests/suite/suite.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go
@zhikh23 zhikh23 marked this pull request as draft December 9, 2025 22:02
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread go.mod

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread tests/suite/suite.go
Comment thread internal/infra/sso/is_admin_provider.go
Comment thread internal/config/sso.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread tests/suite/suite.go
Comment thread cmd/grpc/main.go
@BOBAvov BOBAvov marked this pull request as ready for review December 10, 2025 08:48
@BOBAvov BOBAvov requested review from Copilot and zhikh23 December 10, 2025 08:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread .golangci.yaml Outdated
Comment thread Dockerfile Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread tests/suite/suite.go Outdated
Comment thread internal/config/config.go Outdated
Copilot suggestions

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread tests/suite/suite.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/suite/suite.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go Outdated
Comment thread internal/infra/sso/is_admin_provider.go
Comment thread tests/suite/suite.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants