Skip to content

[Activity Phase 1] Deliver 교육활동 MVP in course detail#404

Draft
cursor[bot] wants to merge 1 commit into
feature/activity-systemfrom
cursor/altsis-education-activity-phase-1-1267
Draft

[Activity Phase 1] Deliver 교육활동 MVP in course detail#404
cursor[bot] wants to merge 1 commit into
feature/activity-systemfrom
cursor/altsis-education-activity-phase-1-1267

Conversation

@cursor

@cursor cursor Bot commented Jun 17, 2026

Copy link
Copy Markdown

Summary

  • Deliver ALTSIS 교육활동(Activity) Phase 1 MVP under course (Syllabus) detail using the existing Alt Board/AltForm/AltSheetRow execution engine.
  • Includes backend models/APIs/services/routes for Activity, ActivityTemplate, and ActivitySubmission with season permission (permissionActivityV2) and CalendarEvent sync using sourceType: "activity".
  • Includes builtin templates: assignment(과제), quiz(퀴즈), discussion(토론) and template flows (create/edit/duplicate/instantiate).
  • Includes frontend activity domain types + useAPIv2 integration (ActivityAPI, ActivityTemplateAPI) and course detail tabs for both mentoring/enrolled views.
  • Hardens MVP visibility rules by blocking non-mentor access to draft activities/submissions at API level (backend/src/controllers/activities.js).

Test Plan

  1. Backend route-level smoke check (manual):
    • Create activity from builtin template via CActivityFromTemplate.
    • Publish activity.
    • Verify student submission lifecycle (not_started -> submitted) and teacher feedback persistence.
  2. Permission check:
    • With permissionActivityV2=true, mentors can manage and enrolled students can submit.
    • Non-mentor users cannot fetch draft activities via API.
  3. Calendar sync check:
    • Confirm due date creates personal CalendarEvent entries with sourceType: "activity" for enrolled students.
  4. Automated tests attempted:
    • cd backend && yarn test
    • Result in this CI environment: fails due pre-existing test setup issues (setupFiles ./env.js missing and @models/* mapper mismatch), unrelated to this change set.

Known Limitations

  • Legacy data may require admin permission setup (permissionActivityV2) and lazy builtin template initialization path.
  • Activity-specific automated backend tests are still not present in this branch.
  • This PR intentionally excludes Phase 2+ scope (evaluation bridge, timeline/dashboard, AI tutor integration, block canvas editor).
Open in Web View Automation 

Co-authored-by: Mr.GoodwaY <mrgoodway@bmrschool.org>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 1 MVP implementation for 교육활동 has been completed and pushed, including a backend hardening fix to block non-mentor API access to draft activities/submissions (backend/src/controllers/activities.js).

Validation notes:

  • Manual/API flow coverage is included in the PR description.
  • backend automated tests could not be executed in this runner due existing test setup issues (jest.setupFiles expects ./env.js, and @models/* mapper points to non-existent path), unrelated to this patch.

Important branch/base note:

  • This automation environment auto-created/reused PR #404 from cursor/altsis-education-activity-phase-1-1267 to feature/activity-system.
  • Requested target base was 399-feature-altsis-next-project-update-to-v20; please retarget the PR base in GitHub UI if required.

View PR

Open in Web View Automation 

Sent by Cursor Automation: ALTSIS Activity System Phase 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant