fixed work with sets and renamed a grayscale color conversion function#3
Open
AndrewBJ wants to merge 1 commit into
Open
fixed work with sets and renamed a grayscale color conversion function#3AndrewBJ wants to merge 1 commit into
AndrewBJ wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with a
clMaroon(=$00000080) parameter which isTColorbut afunction (AGrayScale : Byte)calledA grayscale functions shouldis renamed to
MakeGrayScaleColorsince there is already such a function for make a grayscale colorIncorrect conversion of sets to integers, which led to passing garbage values to api, and as a result - unstable work.
Conversions
PInteger(@ASet)^are changed toSetToInt(ASet, SizeOf(ASet))