-
Notifications
You must be signed in to change notification settings - Fork 0
v0.3.1 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v0.3.1 #8
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f6b4f88
Add static-analysis-redundant test rule and update related configurat…
mattyhansen f55f5ee
Update rule counts and severity levels in rules.md
mattyhansen f6b30ae
Bump version to 0.3.1, add Symfony YAML controller support, and updat…
mattyhansen 1db79ca
Add tests for changed-region accounting and project-wide findings in …
mattyhansen 49a3f67
Fix project-rule finding filter to drop findings on empty file set an…
mattyhansen 090c993
Bump goat-flow version to 1.9.1 and update related documentation
mattyhansen 3f1df52
Refactor analysis options and score calculation logic for improved cl…
mattyhansen 2a14772
Update documentation for configuration and CLI behavior; clarify vers…
mattyhansen a31a2eb
Update composer.lock and enhance dependency-install script for npm ch…
mattyhansen e2638f4
Merge branch 'main' into dev
mattyhansen 1d597b6
Bump goat-flow version to 1.9.2 and update related documentation
mattyhansen eac2725
Update configuration files and documentation; remove classmap-authori…
mattyhansen 5e21dce
Add hook filtering and presentation classes for changed-region analysis
mattyhansen a3f178d
Refactor analysis tests to use runChangedScopeAnalyse method for impr…
mattyhansen 52cbbfb
Enhance hook filtering by adding disambiguated identities for finding…
mattyhansen 1bc6814
Refactor project structure by renaming and reorganizing files; update…
mattyhansen ef99d2a
Update CHANGELOG for version 0.3.1 release; adjust date and summarize…
mattyhansen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "deny-dangerous": { | ||
| "enabled": true, | ||
| "PreToolUse": [ | ||
| { | ||
| "matcher": "run_command|view_file|write_to_file|replace_file_content|multi_replace_file_content", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "bash -c 'gcd=\"$(git rev-parse --git-common-dir 2>/dev/null)\"; root=\"\"; case \"$gcd\" in */.git/modules/*|.git/modules/*) root=\"$(git rev-parse --show-toplevel 2>/dev/null || true)\" ;; /*|[A-Za-z]:/*|[A-Za-z]:\\\\*) gcd=\"${gcd//\\\\//}\"; root=\"$(dirname \"$gcd\")\" ;; *) root=\"$(git rev-parse --show-toplevel 2>/dev/null || true)\" ;; esac; [ -f \"$root/.goat-flow/hooks/deny-dangerous.sh\" ] || root=\"${CLAUDE_PROJECT_DIR:-}\"; [ -f \"$root/.goat-flow/hooks/deny-dangerous.sh\" ] || { printf '\\''{\"decision\":\"deny\",\"reason\":\"Policy hook unavailable: git repository root unavailable.\"}\\n'\\''; exit 0; }; cd \"$root\" || { printf '\\''{\"decision\":\"deny\",\"reason\":\"Policy hook unavailable: git repository root unavailable.\"}\\n'\\''; exit 0; }; bash \"$root/.goat-flow/hooks/deny-dangerous.sh\"'", | ||
| "timeout": 30 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "gruff-code-quality": { | ||
| "enabled": true, | ||
| "PostToolUse": [ | ||
| { | ||
| "matcher": "write_to_file|replace_file_content|multi_replace_file_content", | ||
| "hooks": [ | ||
| { | ||
| "type": "command", | ||
| "command": "bash -c 'gcd=\"$(git rev-parse --git-common-dir 2>/dev/null)\"; root=\"\"; case \"$gcd\" in */.git/modules/*|.git/modules/*) root=\"$(git rev-parse --show-toplevel 2>/dev/null || true)\" ;; /*|[A-Za-z]:/*|[A-Za-z]:\\\\*) gcd=\"${gcd//\\\\//}\"; root=\"$(dirname \"$gcd\")\" ;; *) root=\"$(git rev-parse --show-toplevel 2>/dev/null || true)\" ;; esac; [ -f \"$root/.goat-flow/hooks/gruff-code-quality.sh\" ] || root=\"${CLAUDE_PROJECT_DIR:-}\"; [ -f \"$root/.goat-flow/hooks/gruff-code-quality.sh\" ] || { printf '\\''{\"decision\":\"deny\",\"reason\":\"Policy hook unavailable: git repository root unavailable.\"}\\n'\\''; exit 0; }; cd \"$root\" || { printf '\\''{\"decision\":\"deny\",\"reason\":\"Policy hook unavailable: git repository root unavailable.\"}\\n'\\''; exit 0; }; bash \"$root/.goat-flow/hooks/gruff-code-quality.sh\"'", | ||
| "timeout": 30 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.agents/skills/goat-critique/references/sub-agent-directives.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agents gruff hook denies when missing
Medium Severity
When
.goat-flow/hooks/gruff-code-quality.shis missing, the PostToolUse wrapper emits a JSONdenydecision instead of skipping quietly. That treats an optional quality hook like a hard policy failure and can block or disrupt file edits even though the hook is designed to fail soft.Reviewed by Cursor Bugbot for commit 1bc6814. Configure here.