Skip to content

main-vehicle: allow setting vehicle and stream urls via query#669

Merged
rafaellehmkuhl merged 1 commit into
bluerobotics:masterfrom
Williangalvani:query_urls
Apr 30, 2024
Merged

main-vehicle: allow setting vehicle and stream urls via query#669
rafaellehmkuhl merged 1 commit into
bluerobotics:masterfrom
Williangalvani:query_urls

Conversation

@Williangalvani

Copy link
Copy Markdown
Member

it results in some rather ugly urls, but it works 🤷

@CLAassistant

CLAassistant commented Jan 2, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 5, 2024

@rafaellehmkuhl rafaellehmkuhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working for me.
I've tried accessing a local vehicle (regular URL e.g.: 192.168.0.99) and it didn't connect.
It works fine on master.

Console shows:

WebSocket connection to 'ws://192.168.0.99/ws/mavlink' failed:

It only works if I explicitly set the m2r address as ws://192.168.0.99:6040/ws/mavlink.

@Williangalvani

Copy link
Copy Markdown
Member Author

This is not working for me. I've tried accessing a local vehicle (regular URL e.g.: 192.168.0.99) and it didn't connect. It works fine on master.

Console shows:

WebSocket connection to 'ws://192.168.0.99/ws/mavlink' failed:

It only works if I explicitly set the m2r address as ws://192.168.0.99:6040/ws/mavlink.

I'll fix the pr

@rafaellehmkuhl rafaellehmkuhl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm.

Can I merge it @Williangalvani?

@rafaellehmkuhl rafaellehmkuhl merged commit 6093baa into bluerobotics:master Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-needed Change needs to be documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants