Skip to content

Update mavlink server#3971

Open
joaoantoniocardoso wants to merge 4 commits into
bluerobotics:masterfrom
joaoantoniocardoso:update_mavlink_server
Open

Update mavlink server#3971
joaoantoniocardoso wants to merge 4 commits into
bluerobotics:masterfrom
joaoantoniocardoso:update_mavlink_server

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Jun 30, 2026

Copy link
Copy Markdown
Member

This brings the ZenohRaw endpoint (required by bluerobotics/blueos-recorder#19) and MavFTP.

Changelog here

Summary by Sourcery

Introduce Zenoh Raw endpoint support and update the bundled mavlink-server to version 0.9.0 to enable new capabilities such as the ZenohRaw endpoint and related functionality.

New Features:

  • Add support for Zenoh Raw endpoints throughout the MAVLink server and autopilot manager, including validation and frontend type mapping.

Enhancements:

  • Update the default Zenoh Raw endpoint configuration in the autopilot manager for MAVLink server usage.

Build:

  • Bump bundled mavlink-server version to 0.9.0 in the bootstrap script to align with new features.

@joaoantoniocardoso joaoantoniocardoso marked this pull request as draft June 30, 2026 23:42
sourcery-ai[bot]

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@joaoantoniocardoso joaoantoniocardoso marked this pull request as ready for review July 1, 2026 00:39

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The list of network-based endpoint types is now duplicated between Endpoint.is_mavlink_endpoint and MAVLinkServer._validate_endpoint; consider centralizing the definition of valid network/remote endpoint types to avoid future mismatches.
  • The new ZenohRaw default endpoint in autopilot_manager.py hardcodes port 7117; if this is a convention you expect to reuse, it may be worth defining it as a shared constant or configuration option rather than inline.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The list of network-based endpoint types is now duplicated between `Endpoint.is_mavlink_endpoint` and `MAVLinkServer._validate_endpoint`; consider centralizing the definition of valid network/remote endpoint types to avoid future mismatches.
- The new `ZenohRaw` default endpoint in `autopilot_manager.py` hardcodes port 7117; if this is a convention you expect to reuse, it may be worth defining it as a shared constant or configuration option rather than inline.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant