Changes for jni 0.20.0#15
Merged
Merged
Conversation
bluejekyll
approved these changes
May 14, 2024
bluejekyll
left a comment
Owner
There was a problem hiding this comment.
This looks good. Thanks for the PR!
Contributor
Author
|
@bluejekyll how might I get CI to run? It looks like it was disabled due to inactivity. I'm guessing this is because it was on a cron schedule but there's not been much activity in a while. You might need to push a button but I'm not sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over in #14, I've found that some of the android ndk crates are using jni 0.20. Here are some of those changes:
Fromtrait implementations convertingjni_systypes likejobjecttoJObjecthave been replaced withunsafe::from_rawAutoArrayis no longer tied to the lifetime of a particularJNIEnvreference.I'd like to update to 0.21.0 evenutally but when I tried that, I ended up with 44 errors rather than 3 so let's start small.
Some of the changes are because my vim setup removes white space at the end of lines. I can remove those changes if it pleases you.
When I run
just testlocally, it passes and works.