Skip to content

Changes for jni 0.20.0#15

Merged
bluejekyll merged 1 commit into
bluejekyll:mainfrom
simlay:update-to-jni-0.20
May 14, 2024
Merged

Changes for jni 0.20.0#15
bluejekyll merged 1 commit into
bluejekyll:mainfrom
simlay:update-to-jni-0.20

Conversation

@simlay

@simlay simlay commented May 13, 2024

Copy link
Copy Markdown
Contributor

Over in #14, I've found that some of the android ndk crates are using jni 0.20. Here are some of those changes:

I'd like to update to 0.21.0 evenutally but when I tried that, I ended up with 44 errors rather than 3 so let's start small.

Some of the changes are because my vim setup removes white space at the end of lines. I can remove those changes if it pleases you.

When I run just test locally, it passes and works.

@bluejekyll bluejekyll left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the PR!

@bluejekyll bluejekyll merged commit ace711a into bluejekyll:main May 14, 2024
@simlay simlay deleted the update-to-jni-0.20 branch May 14, 2024 17:48
@simlay

simlay commented May 14, 2024

Copy link
Copy Markdown
Contributor Author

@bluejekyll how might I get CI to run? It looks like it was disabled due to inactivity. I'm guessing this is because it was on a cron schedule but there's not been much activity in a while. You might need to push a button but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants