add support for boolean/bool#12
Merged
Merged
Conversation
simlay
approved these changes
May 13, 2024
simlay
left a comment
simlay
left a comment
Contributor
There was a problem hiding this comment.
@bluejekyll I think these changes seem pretty reasonable. Up to take a look? It looks like CI hasn't ran since march of 2023. I'm up to get it working with the things leading up tojust test but I think github's default CI settings don't run CI for any non-previous contributors to a given repo.
Over in #14, I've slowly made more changes but some changes are obviously experimental and think it'd be good to have more small PRs rather than one big PR.
Owner
|
Oh, I think I missed this PR. Yes, this looks reasonable. |
bluejekyll
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for mapping java
booleans. The only tricky part is thatzalready returns rustbool, butJavaBooleanis actually represented byu8, which makes is incompatible withfrom_java_value!macro.