Skip to content

fix(release-notes): don't persist credentials on release-foundry checkout#58

Merged
nirmal-bluefunda merged 1 commit into
mainfrom
fix/checkout-persist-credentials
Jun 8, 2026
Merged

fix(release-notes): don't persist credentials on release-foundry checkout#58
nirmal-bluefunda merged 1 commit into
mainfrom
fix/checkout-persist-credentials

Conversation

@devops-bda

Copy link
Copy Markdown
Contributor

Summary

  • The Check out release-foundry step in github-release-notes.yml checks out a read-only copy of release-foundry just to build the rf binary — it never pushes back.
  • actions/checkout's post-job "Removing auth" cleanup was failing with exit code 128 (git refuses to operate on the repo by job-end, likely due to ownership changes from the subsequent setup-go/go build steps), marking otherwise-successful jobs as failed.
  • Setting persist-credentials: false skips writing the temporary http.extraheader auth config in the first place, so there's nothing for the post-step cleanup to remove and the failure path is avoided entirely.

Test plan

  • Trigger the GitHub Release Notes reusable workflow (e.g. via a release in a calling repo) and confirm the job completes without the Removing auth / exit code 128 failure
  • Confirm the release notes are still generated and the release body is updated as expected

🤖 Generated with Claude Code

…kout

The post-job "Removing auth" cleanup for this read-only checkout fails
with exit 128 (git refuses to operate on the repo by job-end, e.g. due
to ownership changes from the subsequent go build/setup-go steps).
Since this checkout is only used to build the rf binary and never
pushes back, skipping credential persistence avoids the cleanup path
entirely.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nirmal-bluefunda nirmal-bluefunda merged commit 1ee2776 into main Jun 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants