feat(serve): allow starting without static SAP credentials#70
Merged
Conversation
When no system is configured in systems.json and SAP_HOST/SAP_USERNAME/ SAP_PASSWORD env vars are absent, the server now starts in multi-system mode (credentials supplied per-request via X-SAP-* headers) instead of refusing to start. Matches the abaper-ts behaviour, enabling deployment without baked-in SAP credentials. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
devops-bda
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servecommand now starts in multi-system mode when no SAP system is configured (nosystems.jsonactive system and noSAP_HOST/SAP_USERNAME/SAP_PASSWORDenv vars)X-SAP-*headers, matching the behaviour ofabaper-tssystems.jsonor env vars), behaviour is unchanged — static client is authenticated at startup as beforeMotivation
Enables deploying the
abaperREST server to theappsnode without baking in static SAP credentials, consistent with howabaper-tsis deployed in production (pure multi-system mode, credentials forwarded per-request from the gateway).Test plan
abaper servewith no config/env vars — server starts,GET /healthreturns{"adt_status":"disconnected","status":"healthy"}abaper servewithSAP_HOST/SAP_USERNAME/SAP_PASSWORDset — authenticates at startup,GET /healthreturns{"adt_status":"connected"}abaper servewith a configured system insystems.json— same as above🤖 Generated with Claude Code