fix(adt,docker): endpoint/parser fixes for 100% abaper-ts parity + Docker build fix#69
Merged
Merged
Conversation
Verified live against a4h with abaper-ts running side-by-side (17/17 PASS). SDK fixes: - FormatSource: use /abapsource/prettyprinter (not /repository/formatters/format) - GetCompletionProposals: use source URI (/source/main suffix) + Accept: application/vnd.sap.as+xml - GetNavigationTarget: use source URI with #start=L,C;end=L,C fragment + Accept: application/* - GetTransportInfo: replace lock-based fallback with POST /cts/transportchecks using application/vnd.sap.as+xml dataname=com.sap.adt.transport.service.checkData; fix XML parser path to DATA>REQUESTS>CTS_REQUEST>REQ_HEADER - SyntaxCheck: remove unused lockInfoXML type REST server fix: - getObjectHandler: add FUNCTIONGROUP/FUGR case → GetFunctionGroup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
devops-bda
approved these changes
Jun 4, 2026
phanikumarps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes bundled together.
1. ADT endpoint/parser fixes (17/17 parity tests PASS vs abaper-ts)
FormatSource: correct endpoint is/abapsource/prettyprinter(not/repository/formatters/format)GetCompletionProposals: source URI (/source/mainsuffix) +Accept: application/vnd.sap.as+xmlGetNavigationTarget: source URI with#start=L,C;end=L,Cfragment +Accept: application/*GetTransportInfo: fallback usesPOST /cts/transportcheckswith correct media type; XML path fixed toDATA>REQUESTS>CTS_REQUEST>REQ_HEADERgetObjectHandler: add missingFUNCTIONGROUP/FUGRcase2. Docker build fix (matches org standard from template-go)
Dockerfile: was hardcodinggolang:1.25-alpine, causinggo mod downloadto fail (go.mod requires >= 1.26.0); now usesARG GO_VERSION=1.26release.yml: addspreparejob that readsGO_VERSIONfromgo.modand injects it as Docker build-arg — no manual version sync neededTest plan
ARG GO_VERSIONpattern matchestemplate-goDockerfile org standard🤖 Generated with Claude Code