Closed
Conversation
…r usage - Extract duplicated PointerXY tap/hover handler from LineResult and HeatmapResult into _build_tap_plot() on the HoloviewResult base class - Extract duplicated over_time HoloMap iteration loop into _build_time_holomap() on the base class - Unify ScatterResult to use self.filter() instead of PlotFilter directly and add result_var parameter for consistency - Remove dead commented-out code (ScatterResult, LineResult, HeatmapResult) - Remove redundant to_heatmap_single() that bypassed the filter pipeline - Fix layout_plots() bug that called plot_callback twice per result var - Collapse redundant to_plot/to_X delegation: to_X is the implementation, to_plot is a thin alias (preserves MRO safety with BenchResult) - Net reduction of ~226 lines with no behavioral changes https://claude.ai/code/session_01ScwtKEtxGn7RScGV6JQy7f
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
4 tasks
Owner
Author
|
Closing in favor of #754, which is a cleaned-up version of this same refactoring with test updates included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.