Skip to content

Fix/mobile layout issues#1805

Open
brunod-e wants to merge 11 commits intodevfrom
fix/mobile-layout-issues
Open

Fix/mobile layout issues#1805
brunod-e wants to merge 11 commits intodevfrom
fix/mobile-layout-issues

Conversation

@brunod-e
Copy link
Copy Markdown
Collaborator

@brunod-e brunod-e commented Apr 7, 2026

No description provided.

@brunod-e brunod-e self-assigned this Apr 7, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
anticapture Ready Ready Preview, Comment Apr 10, 2026 11:17am
anticapture-storybook Ready Ready Preview, Comment Apr 10, 2026 11:17am

Request Review

@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/blockful/anticapture/blob/ed2b88ee60651edd3fdb198e7c9a0026034927f6/apps/dashboard/app/[daoId]/(main)/governance/offchain-proposal/[proposalId]/page.tsx#L38-L41
P1 Badge Remove duplicated layout shell from offchain proposal page

This route was moved under (main) in this commit, so it now inherits apps/dashboard/app/[daoId]/(main)/layout.tsx, which already renders the sidebars, mobile headers, and footer. Keeping a second full-page shell here (h-screen wrapper + HeaderSidebar/HeaderMobile/StickyPageHeader/Footer) causes nested chrome and broken layout/scroll behavior specifically on /[daoId]/governance/offchain-proposal/[proposalId], while the sibling governance pages in the same commit were simplified to avoid exactly this.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@isadorable-png
Copy link
Copy Markdown
Collaborator

isadorable-png commented Apr 9, 2026

🎨 UI Review — PR #1805 Fix/mobile layout issues

Automated review by Claude · Preview (auth-gated, code-only review)


Mobile Header / Navigation

  • Header spacer mismatch: HeaderMobile.tsx moved the menu overlay from top-[98px]top-[124px], meaning the fixed header is now 124px tall. But the spacer <div> in StickyPageHeader.tsx:84 is still h-[98px]. ~26px of page content is hidden under the fixed header (as you can see Shutter banner is hidden). Fix: update spacer to h-[124px], or extract the height as a shared constant. (widgets/StickyPageHeader.tsx:84, widgets/HeaderMobile.tsx:144)
  • Page/body margin-top is too big, it should be 20px.
image
  • On mobile, the browser navigation (where container the URL) is overlapping the content if you go to the bottom, the website needs to be able to respond to that.
image
  • Select nav broken on nested routes: currentPage is derived from pathname.split("/").filter(Boolean).pop() — returns the last path segment. On /ens/governance/proposal/123, this returns "123", which matches no item, so the Select shows "Navigate to…" instead of "Proposals" as the active section. Fix: match against known route segments rather than last segment (e.g. options.find(o => pathname.includes(o.page))). (widgets/HeaderNavMobile.tsx:73)
  • We should hide the dropdown or let the proposal navbar get sticky (the one with the VP and with the back button).
image
  • This is looking really weird. Anticapture navigation should come first and the DAO in second place as the user scrolls.

  • There's a bug that the feature dropdown is showing a bit without the user scrolling.

  • Proposal details sticky tabs are not working properly.

image
  • Change the alignment of the action from columns to rows.
image
  • Cast your vote should be a drawer, not a modal.
image
  • Button should be full-width on the spp header.
  • first tab table is broken.

Proposal Detail

Queue / Execute buttons

  • Both Queue Proposal and Execute Proposal buttons have className="hidden lg:flex" — they don't exist on mobile. These are critical governance actions; users on mobile can't queue or execute proposals. Needs a mobile equivalent (sticky bottom bar or drawer trigger). (features/governance/components/proposal-overview/ProposalHeader.tsx:155, 165)

GovernanceActionModal (new)

  • Step icons use hardcoded text-black — use text-primary (maps to --base-foreground): affects PenLine and Hourglass icons. (features/governance/components/modals/GovernanceActionModal.tsx:145, 157)
  • Spinner uses text-orange-500 — not a design token. Use text-warning if available in globals.css, otherwise text-muted. (same file, ~line 166)
  • StepRow icon: outer container is size-6 (24px) but inner div has p-2 + size-3.5 icon (14px + 16px padding = 30px) — inner overflows outer by 6px. Change inner p-2p-1, or remove the nested div and apply rounded-full border directly to the outer. (same file, ~line 181)

Copy link
Copy Markdown
Collaborator

@isadorable-png isadorable-png left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/blockful/anticapture/blob/dbbe980f02c3a99248a1d0e6ab6933d5ae05c056/apps/dashboard/app/[daoId]/(main)/governance/offchain-proposal/[proposalId]/page.tsx#L38-L40
P1 Badge Remove duplicated app shell from offchain proposal page

This page was moved into app/[daoId]/(main) (which already wraps children with HeaderMobile, StickyPageHeader, sidebars, and Footer), but it still renders its own full shell. On /[daoId]/governance/offchain-proposal/[proposalId] that creates nested h-screen containers and duplicated headers/footers, which breaks layout/scroll behavior and causes overlapping chrome. The page should mirror the updated governance/proposal pages and render only the section content.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants