Feat/offchain non voters by LeonardoVieira1630 · Pull Request #1794 · blockful/anticapture

LeonardoVieira1630 · 2026-03-31T16:09:02Z

Summary

Add a new API endpoint (GET /offchain/proposals/{id}/non-voters) that returns active delegates who did not vote on a given offchain (Snapshot) proposal, enabling governance participation analysis. This also normalizes addresses to checksummed format in the offchain indexer to ensure consistent cross-schema joins.

Changes

API endpoint & controller (apps/api/src/controllers/votes/offchainNonVoters.ts): New OpenAPI route wired to the Hono app that accepts proposal ID, pagination, ordering, and optional address filter params
Repository (apps/api/src/repositories/votes/offchainNonVoters.ts): Cross-schema query using a LEFT JOIN between accountPower (public schema) and offchainVotes (snapshot schema) to identify delegates with voting power > 0 who did not vote, with pagination and address filtering
Unified Drizzle client (apps/api/src/database/index.ts, apps/api/cmd/index.ts): New UnifiedDrizzle type and pgUnifiedClient instance combining both schemas to support cross-schema queries
Service layer (apps/api/src/services/votes/offchainNonVoters.ts): Orchestrates repository calls, converts bigint voting power to string, and optimizes totalCount by using addresses.length when a filter is provided
Zod schemas (apps/api/src/mappers/proposals/offchainVoters.ts): Request/response validation schemas for the non-voters endpoint
Address normalization (apps/offchain-indexer/src/mappers/proposal.ts, apps/offchain-indexer/src/mappers/vote.ts): Added viem's getAddress transform to ensure proposal authors and voters are stored as EIP-55 checksummed addresses
Tests: Integration tests for the repository (PGlite-based) and unit tests for the service layer covering pagination, ordering, address filtering, and edge cases
Gateway schema (apps/api-gateway/schema.graphql): Regenerated with the new offchainProposalNonVoters query and enriched field descriptions

Adds UnifiedDrizzle type (public + snapshot schemas combined) and a _pgUnifiedClient in cmd/index.ts for future cross-schema queries such as offchain non-voters. Applied fallback plan: existing offchain repos keep OffchainDrizzle; _pgUnifiedClient is reserved for the new repository. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Implements the service layer (bigint→string conversion, totalCount logic) and OpenAPI controller for GET /offchain/proposals/{id}/non-voters, wiring OffchainNonVotersRepositoryImpl through the unified Drizzle client. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

vercel · 2026-03-31T16:09:56Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
anticapture	Ready	Preview, Comment	Apr 9, 2026 4:58pm
anticapture-storybook	Ready	Preview, Comment	Apr 9, 2026 4:58pm

claude · 2026-03-31T17:40:49Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 340b6d87ad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/api-gateway/schema.graphql

apps/api/src/services/votes/offchainNonVoters.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3313d67962

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/api/src/mappers/votes/offchainVotes.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dff54aa7f6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/api-gateway/schema.graphql

apps/api/cmd/index.ts

apps/api/src/repositories/votes/offchainNonVoters.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53e5ea6d5b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

packages/graphql-client/documents/governance/offchainVotes.graphql

Only DAOs that support offchain data now get a unified pg client and offchain route registration, removing the always-eager pgOffchainClient and pgUnifiedClient. Repos updated to accept UnifiedDrizzle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cef2e7ac6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/api/cmd/index.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c63270639

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/offchain-indexer/src/indexer.ts

…oters' into feat/offchain_non_voters

LeonardoVieira1630 and others added 8 commits March 26, 2026 17:45

feat: add Zod schemas for offchain non-voters endpoint

93d7e77

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: normalize addresses to checksummed format in offchain indexer

c92002d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: add offchain non-voters repository with cross-schema query

7cb712c

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: add offchain non-voters service unit tests

ecac8e0

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test: add offchain non-voters repository integration tests

deb2685

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: schema

45a70df

LeonardoVieira1630 self-assigned this Mar 31, 2026

LeonardoVieira1630 added the enhancement Improving an already existing feature label Mar 31, 2026

LeonardoVieira1630 added 2 commits March 31, 2026 14:05

refactor: unnecessary schema

177f350

feat: missing property on test

cb5400c

vercel bot temporarily deployed to Preview – anticapture-storybook March 31, 2026 17:08 Inactive

vercel bot deployed to Preview – anticapture March 31, 2026 17:09 View deployment

feat: generated schema

0ebe5e2

vercel bot temporarily deployed to Preview – anticapture-storybook March 31, 2026 17:38 Inactive

Merge branch 'dev' into feat/offchain_non_voters

340b6d8

github-actions bot added API Indexer Gateway labels Mar 31, 2026

LeonardoVieira1630 marked this pull request as ready for review March 31, 2026 17:40

LeonardoVieira1630 requested review from PedroBinotto and pikonha as code owners March 31, 2026 17:40

vercel bot had a problem deploying to Preview – anticapture-storybook March 31, 2026 17:40 Failure

vercel bot deployed to Preview – anticapture March 31, 2026 17:41 View deployment

refactor: schema

f6d578f

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

apps/api-gateway/schema.graphql Outdated Show resolved Hide resolved

apps/api-gateway/schema.graphql Show resolved Hide resolved

apps/api/src/services/votes/offchainNonVoters.ts Outdated Show resolved Hide resolved

refactor: duplicated property on tests

1af112f

vercel bot temporarily deployed to Preview – anticapture-storybook April 6, 2026 16:53 Inactive

vercel bot deployed to Preview – anticapture April 6, 2026 16:54 View deployment

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

apps/api/src/mappers/votes/offchainVotes.ts Outdated Show resolved Hide resolved

Merge branch 'dev' into feat/offchain_non_voters

dff54aa

vercel bot had a problem deploying to Preview – anticapture-storybook April 7, 2026 16:49 Failure

vercel bot had a problem deploying to Preview – anticapture April 7, 2026 16:49 Failure

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

apps/api-gateway/schema.graphql Show resolved Hide resolved

Merge branch 'dev' into feat/offchain_non_voters

9a0b3a9

vercel bot had a problem deploying to Preview – anticapture-storybook April 8, 2026 16:20 Failure

vercel bot had a problem deploying to Preview – anticapture April 8, 2026 16:21 Failure

pikonha approved these changes Apr 8, 2026

View reviewed changes

apps/api/cmd/index.ts Outdated Show resolved Hide resolved

apps/api/src/repositories/votes/offchainNonVoters.ts Show resolved Hide resolved

refactor: choice on dashboard

53e5ea6

LeonardoVieira1630 requested a review from alextnetto as a code owner April 8, 2026 19:06

vercel bot deployed to Preview – anticapture-storybook April 8, 2026 19:07 View deployment

vercel bot deployed to Preview – anticapture April 8, 2026 19:08 View deployment

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

packages/graphql-client/documents/governance/offchainVotes.graphql Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview – anticapture-storybook April 8, 2026 19:19 Inactive

vercel bot deployed to Preview – anticapture April 8, 2026 19:20 View deployment

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

apps/api/cmd/index.ts Show resolved Hide resolved

Merge branch 'dev' into feat/offchain_non_voters

6c63270

vercel bot deployed to Preview – anticapture-storybook April 9, 2026 16:42 View deployment

vercel bot deployed to Preview – anticapture April 9, 2026 16:43 View deployment

chatgpt-codex-connector bot reviewed Apr 9, 2026

View reviewed changes

apps/offchain-indexer/src/indexer.ts Show resolved Hide resolved

LeonardoVieira1630 added 2 commits April 9, 2026 13:55

refactor: choice to be handled as a string[]

3f9f94f

Merge remote-tracking branch 'refs/remotes/origin/feat/offchain_non_v…

2fbea68

…oters' into feat/offchain_non_voters

vercel bot deployed to Preview – anticapture-storybook April 9, 2026 16:57 View deployment

vercel bot deployed to Preview – anticapture April 9, 2026 16:58 View deployment

LeonardoVieira1630 merged commit cfb7d08 into dev Apr 9, 2026
6 checks passed

LeonardoVieira1630 deleted the feat/offchain_non_voters branch April 9, 2026 17:08

Conversation

LeonardoVieira1630 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Uh oh!

vercel bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LeonardoVieira1630 commented Mar 31, 2026 •

edited

Loading

vercel bot commented Mar 31, 2026 •

edited

Loading

claude bot commented Mar 31, 2026 •

edited

Loading