refactor: convert function declarations to arrow functions#1788
refactor: convert function declarations to arrow functions#1788
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c484c7ce8c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ], | ||
|
|
||
| // Enforce arrow-function expressions over function declarations | ||
| "func-style": ["error", "expression"], |
There was a problem hiding this comment.
Applying "func-style": ["error", "expression"] to all apps/dashboard/**/* files makes every remaining function declaration a hard lint error, but this commit does not migrate all of them (for example apps/dashboard/app/contact/page.tsx, apps/dashboard/app/layout.tsx, and apps/dashboard/app/robots.ts still use function declarations). In any workflow that runs repo linting, this change will fail CI immediately and block unrelated work until a full migration is completed or the rule is scoped down.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
although I'm not sue why is this PR even needed, this should be fixed
2 participants
No description provided.