feat: add governance action modal and integrate queue/execute functions by brunod-e · Pull Request #1784 · blockful/anticapture

brunod-e · 2026-03-25T20:55:30Z

No description provided.

…nality

vercel · 2026-03-25T20:55:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
anticapture	Ready	Preview, Comment	Apr 10, 2026 5:40pm
anticapture-storybook	Ready	Preview, Comment	Apr 10, 2026 5:40pm

claude · 2026-03-25T20:55:55Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

…ibility

…tional calldatas

claude · 2026-04-06T14:15:47Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81b161426a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-06T14:21:03Z

apps/dashboard/features/governance/components/proposal-overview/ProposalHeader.tsx

+              <Button
+                className="hidden lg:flex"
+                onClick={() => setIsQueueModalOpen(true)}
+              >
+                Queue Proposal


Restrict governance action buttons to valid states

These CTAs are rendered unconditionally, so users can open queue/execute flows for proposals that are not actionable (for example ongoing or defeated) and even while disconnected. In those cases the modal either fails on-chain with a revert or sits in a waiting state because handleAction exits early when no wallet/account is available, which creates a broken primary flow for proposal pages. Please gate these buttons by both wallet connection and the expected status transitions (succeeded for queue, pending_execution/queued for execute).

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-06T14:21:03Z

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

+      abi: GovernorQueueAbi,
+      address,
+      functionName: "queue",
+      args: contractArgs,


Add DAO-specific action routing before queue calls

This utility always submits OpenZeppelin-style queue/execute(targets,values,calldatas,descriptionHash) calls for every DAO, but at least SHU uses Azorius governance (its ABI exposes executeProposal rather than OZ queue/execute). As a result, governance actions for SHU will fail during simulation/send even when the proposal is otherwise executable. This needs DAO-specific dispatch similar to the vote handler selection logic, or explicit exclusion of unsupported DAOs.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68fe14f863

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-06T18:41:56Z

apps/dashboard/features/holders-and-delegates/delegate/DelegationModal.tsx

    | Address
    | undefined;
+  const chain = daoConfig?.daoOverview?.chain;
+  const { data: walletClient } = useWalletClient({ chainId: chain?.id });


Handle wrong-chain wallets before opening delegation flow

Using useWalletClient({ chainId }) returns no wallet client when the user is connected on a different network; with this change, the modal now enters the waiting state but never progresses because both the effect and action handler require a truthy walletClient. In that scenario users see an indefinite "confirm in wallet" step with no network-switch prompt or error, so delegation is effectively blocked unless they manually discover the chain mismatch.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-06T18:41:56Z

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

+  account: Address,
+): ActionArgs => {
+  return {
+    targets: proposalTargets.map((t) => (t ?? "0x") as `0x${string}`),


Validate null targets instead of coercing to invalid address

This conversion turns missing targets into "0x", which is not a valid address, so any proposal payload containing a null target (the function explicitly accepts (string | null)[]) will fail during simulateContract before transaction submission. That makes queue/execute unusable for those records and hides the underlying data problem behind a low-level address error; input validation with a clear message is safer than placeholder coercion.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93f0ac28b7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

chatgpt-codex-connector · 2026-04-06T21:02:54Z

apps/dashboard/features/governance/components/modals/GovernanceActionModal.tsx

+  }, [address, walletClient, step, action, proposal, daoId, onClose, chain]);
+
+  useEffect(() => {
+    if (!isOpen || !walletClient || step !== "waiting-signature") return;


Surface wrong-chain state before auto-submitting action

This effect exits when walletClient is undefined, but the modal still renders the active "confirm in wallet" step; with useWalletClient({ chainId }), that undefined case happens whenever the user is connected on the wrong network. Because the header buttons are gated by address (not chain), users can open queue/execute and get stuck in an indefinite waiting state with no network-switch prompt or error.

Useful? React with 👍 / 👎.

pikonha · 2026-04-09T14:08:46Z

apps/dashboard/shared/services/wallet/wallet.ts

-import { mainnet } from "wagmi/chains";
+import { mainnet, optimism, scroll } from "wagmi/chains";

 const alchemyApiKey = process.env.NEXT_PUBLIC_ALCHEMY_KEY;


this will leak the alchemy api key

The key was already exposed in the client-side bundle. Not introduced here. But I did a research here and looks like exposing alchemy key is normal because on alchemy dashboard we relate the key with a specific domain. So, no problems exposing it.

apps/dashboard/features/governance/components/proposal-overview/ProposalSection.tsx

pikonha · 2026-04-09T14:10:14Z

apps/dashboard/features/governance/components/proposal-overview/ProposalHeader.tsx

              />
+              {address &&
+                proposalStatus === "succeeded" &&
+                daoId.toUpperCase() !== DaoIdEnum.SHU && (


why is Shutter different??

SHU uses Azorius governance which has no queue step, proposals go directly to execute

apps/dashboard/features/governance/components/modals/GovernanceActionModal.tsx

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

pikonha · 2026-04-09T14:13:09Z

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

+  proposalTargets: (string | null)[],
+  proposalValues: (string | null)[],
+  proposalCalldatas: (string | null)[],


can they even be null?

graphql schema returns (Maybe< String >[]). thats why

pikonha · 2026-04-09T14:13:32Z

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

+  proposalTargets: (string | null)[],
+  proposalValues: (string | null)[],
+  proposalCalldatas: (string | null)[],


why would you have this as null?

graphql schema returns (Maybe< String >[]). thats why

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

…rocessing

…and descriptionHash

…lldatas

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bca9397988

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T17:24:42Z

apps/dashboard/features/governance/components/modals/GovernanceActionModal.tsx

+        proposal.targets.filter((t) => t !== null),
+        proposal.values.filter((v) => v !== null),
+        (proposal.calldatas ?? []).filter((c) => c !== null),


Keep governance payload arrays index-aligned

handleAction removes nulls from targets, values, and calldatas independently, which can desynchronize operations whenever one list has a null at a different index. In that scenario, queue/execute can revert on array-length mismatch or submit mismatched target/value/calldata tuples. Because the proposal fields are typed as nullable lists, this is a reachable production path for malformed records; these arrays should be validated and transformed in lockstep (or rejected) instead of filtered separately.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5bbbae4c2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T17:46:49Z

apps/dashboard/features/governance/utils/submitGovernanceAction.ts

+    case DaoIdEnum.UNISWAP:
+    case DaoIdEnum.NOUNS: {


Route Lil Nouns actions through GovernorBravo path

This switch only special-cases UNI and NOUNS, so LIL_NOUNS falls into the default OpenZeppelin 4-arg queue/execute path. Fresh evidence: apps/api/src/lib/client.ts maps DaoIdEnum.LIL_NOUNS to NounsClient, and Nouns-style governors expose proposal-id-based queue/execute calls; using the 4-arg call shape here will fail simulation/submission and block governance actions for Lil Nouns proposals.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-10T17:46:49Z

apps/dashboard/features/governance/components/proposal-overview/ProposalHeader.tsx

+                  <Button
+                    className="hidden lg:flex"
+                    onClick={() => setIsQueueModalOpen(true)}


Expose queue/execute actions on mobile proposal pages

The new queue/execute CTA is desktop-only (hidden lg:flex), and this change does not add any mobile trigger for the new modals (the mobile bottom bar still only wires voting). On mobile viewports, users cannot open queue/execute flows for succeeded/queued proposals, so governance lifecycle actions are unavailable on phones/tablets.

Useful? React with 👍 / 👎.

feat: add governance action modal and integrate queue/execute functio…

7719392

…nality

brunod-e self-assigned this Mar 25, 2026

brunod-e requested review from isadorable-png and pikonha as code owners March 25, 2026 20:55

brunod-e marked this pull request as draft March 25, 2026 20:55

github-actions bot added the Dashboard label Mar 25, 2026

vercel bot deployed to Preview – anticapture-storybook March 25, 2026 20:56 View deployment

vercel bot deployed to Preview – anticapture March 25, 2026 20:56 View deployment

fix: normalize proposal status to lowercase for consistent button vis…

84bb9a5

…ibility

vercel bot deployed to Preview – anticapture-storybook March 25, 2026 21:04 View deployment

vercel bot deployed to Preview – anticapture March 25, 2026 21:05 View deployment

brunod-e added 2 commits April 2, 2026 09:49

Merge branch 'dev' into feat/add-execute-and-queue-buttons

b8ece5f

refactor: update proposal type in GovernanceActionModal and handle op…

5610671

…tional calldatas

vercel bot had a problem deploying to Preview – anticapture-storybook April 2, 2026 12:54 Failure

vercel bot deployed to Preview – anticapture April 2, 2026 12:56 View deployment

pikonha marked this pull request as ready for review April 6, 2026 14:15

Merge branch 'dev' into feat/add-execute-and-queue-buttons

81b1614

vercel bot had a problem deploying to Preview – anticapture-storybook April 6, 2026 14:16 Failure

vercel bot had a problem deploying to Preview – anticapture April 6, 2026 14:16 Failure

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

Merge branch 'dev' into feat/add-execute-and-queue-buttons

68fe14f

vercel bot deployed to Preview – anticapture-storybook April 6, 2026 18:36 View deployment

vercel bot deployed to Preview – anticapture April 6, 2026 18:37 View deployment

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

brunod-e added 2 commits April 6, 2026 17:50

feat: add execute and queue buttons for proposal actions

3a59284

refactor: streamline submitAction logic for governance proposals

93f0ac2

vercel bot deployed to Preview – anticapture-storybook April 6, 2026 20:57 View deployment

vercel bot deployed to Preview – anticapture April 6, 2026 20:57 View deployment

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

pikonha reviewed Apr 9, 2026

View reviewed changes

apps/dashboard/features/governance/components/proposal-overview/ProposalSection.tsx Outdated Show resolved Hide resolved

pikonha requested changes Apr 9, 2026

View reviewed changes

feat: enhance governance action handling and clean up proposal data p…

bca9397

…rocessing

vercel bot deployed to Preview – anticapture-storybook April 10, 2026 17:18 View deployment

vercel bot deployed to Preview – anticapture April 10, 2026 17:19 View deployment

brunod-e added 2 commits April 10, 2026 14:19

fix: update ActionArgs type to use Address[] for targets, calldatas, …

6bac97d

…and descriptionHash

feat: update proposal handling to use Address type for targets and ca…

ccea19c

…lldatas

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

feat: enhance governance action handling with wallet network validation

d5bbbae

vercel bot deployed to Preview – anticapture-storybook April 10, 2026 17:39 View deployment

vercel bot deployed to Preview – anticapture April 10, 2026 17:40 View deployment

chatgpt-codex-connector bot reviewed Apr 10, 2026

View reviewed changes

Conversation

brunod-e commented Mar 25, 2026

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

pikonha Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

brunod-e Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pikonha Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

brunod-e Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pikonha Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

brunod-e Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pikonha Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

brunod-e Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

vercel bot commented Mar 25, 2026 •

edited

Loading

claude bot commented Mar 25, 2026 •

edited

Loading

claude bot commented Apr 6, 2026 •

edited

Loading

brunod-e Apr 10, 2026 •

edited

Loading

brunod-e Apr 10, 2026 •

edited

Loading