feat: metadata-driven env injection and runtime dropdown UX overhaul#791
Merged
wpfleger96 merged 1 commit intoMay 29, 2026
Conversation
… dropdown UX Replace hardcoded GOOSE_MODE injection with a metadata-driven default_env loop on KnownAcpRuntime, and inject GOOSE_MODEL via model_env_var for runtimes that don't support ACP model switching. This ensures goose agents respect PersonaRecord.model even without a persona pack. Redesign the AddChannelBotDialog runtime dropdown: defaults to "Use persona defaults" (unset) instead of auto-selecting the first runtime. Explicit selection overrides all personas. Per-persona runtime badges on chips show the effective runtime with warning styling when overridden or when a stored preference is unavailable.
5172532
into
worktree-wpfleger+fix-model-picker-runtime-ux
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #783 (provider→runtime rename). Consumes the
KnownAcpRuntimecapability metadata fields added in Phase 2 and redesigns the runtime dropdown in the "Add agents" dialog.Rust (env injection):
GOOSE_MODE=autoinjection with a metadata-drivendefault_envloop — new runtimes get their defaults by adding to the catalog, not touching spawn logicGOOSE_MODELviamodel_env_varfor runtimes that don't support ACP model switching, so goose agents respectPersonaRecord.modeleven without a persona packagent_models.rs#[allow(dead_code)]from the three now-consumed fields (supports_acp_model_switching,model_env_var,default_env)TypeScript (runtime dropdown UX):
resolvePersonaRuntimegains aforceOverrideparameter and anisOverriddenfield on the result type — single source of truth for override decisionsuseEffectiveRuntimeshook extracted fromAddChannelBotDialogfor file size and testabilityRuntimeBadgeextracted as a named component from inline IIFERUNTIME_NONE_SENTINELconstant replaces magic stringisOverriddensemantics