Skip to content

Conversation

@stevenle
Copy link
Member

Summary

  • add the dependencyGraphApi experiment flag to root-cms configuration
  • build a dependency graph service that records draft and published doc references
  • run the dependency graph updater from the cron runner when the experiment is enabled

Testing

  • Not run (not requested)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +205 to +209
for (const collectionId of collectionIds) {
const collectionPath = `Projects/${this.projectId}/Collections/${collectionId}/${modeCollection}`;
const query: Query = this.db
.collection(collectionPath)
.where('sys.modifiedAt', '>=', ts);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Detect newly published docs when building dependency graph

The dependency-graph cron only scans docs whose sys.modifiedAt is newer than the last run (dependency-graph.ts lines 205-209), but publishing a doc does not bump sys.modifiedAt—publish flows set publishedAt and copy the existing sys data (see packages/root-cms/core/client.ts publishDocs and publishScheduledDocs around lines 461‑474 and 597‑610). If a draft was last edited before the previous cron run but then gets published afterward (a common scheduled-publish path), it will never match this filter; yet the cron still advances dependencyGraphApiLastRun, so the published dependency graph silently misses that document until someone edits it again.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants