fix(macos): persist CEF cookies via global request context#369
Open
COCPORN wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix(macos): persist CEF cookies via global request context#369COCPORN wants to merge 1 commit intoblackboardsh:mainfrom
COCPORN wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
CefRequestContext::CreateContext with custom cache_path fails in Chrome runtime with "Cannot create profile at path". Use the global request context for persistent partitions instead — it already has a working profile at root_cache_path/Default with proper cookie persistence. Also pass partition option through BrowserWindow to BrowserView so apps can specify partition when creating windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CefRequestContext::CreateContextwith a customcache_pathfails in Chrome runtime mode ("Cannot create profile at path"). Switches toCefRequestContext::GetGlobalContext()which persists cookies to the default cache location.partitionoption passthrough to BrowserWindow so the partition identifier reaches the native layer.Test plan
🤖 Generated with Claude Code