Skip to content

Fix Tar in bunx electrobun init on windows & ignore node #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullDev wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −3
Open

Fix Tar in bunx electrobun init on windows & ignore node #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcab7a0
use correct system tar command on windows
NullDev Mar 27, 2026
c2ce551
actually use bun for the init to not depend on node
NullDev Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions package/bin/electrobun.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env node
#!/usr/bin/env bun

const { execSync, spawn } = require('child_process');
const { existsSync, mkdirSync, unlinkSync, chmodSync, copyFileSync, createWriteStream } = require('fs');
Expand Down Expand Up @@ -32,18 +32,37 @@ const platform = getPlatform();
const arch = platform === 'win' ? 'x64' : getArch();
const binExt = platform === 'win' ? '.exe' : '';

// On Windows, ensure we use the system tar (C:\Windows\System32\tar.exe)
// rather than Cygwin, Git Bash, or GnuWin32
function getTarCommand() {
if (platform !== 'win') {
return 'tar';
}
const systemTar = join(process.env.SystemRoot || 'C:\\Windows', 'System32', 'tar.exe');
if (existsSync(systemTar)) {
return `"${systemTar}"`;
}
// Fall back to whatever tar is on PATH
return 'tar';
}

// Paths
const electrobunDir = join(__dirname, '..');
const cacheDir = join(electrobunDir, '.cache');
const cliBinary = join(cacheDir, `electrobun${binExt}`);

/**
* @param {string} url
* @param {string} filePath
* @return {Promise<void>}
*/
async function downloadFile(url, filePath) {
return new Promise((resolve, reject) => {
mkdirSync(dirname(filePath), { recursive: true });
const file = createWriteStream(filePath);

https.get(url, {agent}, (response) => {
if (response.statusCode === 302 || response.statusCode === 301) {
if ((response.statusCode === 302 || response.statusCode === 301) && response.headers.location) {
// Follow redirect
return downloadFile(response.headers.location, filePath).then(resolve).catch(reject);
}
Expand Down Expand Up @@ -98,7 +117,7 @@ async function ensureCliBinary() {
await downloadFile(tarballUrl, tarballPath);

// Extract using system tar (available on macOS, Linux, and Windows 10+)
execSync(`tar -xzf "${tarballPath}"`, { cwd: cacheDir, stdio: 'pipe' });
execSync(`${getTarCommand()} -xzf "${tarballPath}"`, { cwd: cacheDir, stdio: 'pipe' });

// Clean up tarball
unlinkSync(tarballPath);
Expand Down