fix(core): allow null for BrowserView.ptr type null assignment#350
Open
AhmedNAgy25 wants to merge 1 commit intoblackboardsh:mainfrom
Open
fix(core): allow null for BrowserView.ptr type null assignment#350AhmedNAgy25 wants to merge 1 commit intoblackboardsh:mainfrom
AhmedNAgy25 wants to merge 1 commit intoblackboardsh:mainfrom
Conversation
- Change ptr from 'Pointer!' to 'Pointer | null = null' - Remove 'as any' type hack when setting ptr to null in remove() - Improves TypeScript type safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a TypeScript type safety issue in
BrowserViewby properly allowingnullvalues for theptrproperty.ptrfromPointer!(non-null assertion) toPointer | null = nullnull as anytype hack in theremove()methodWhy
The
ptrproperty represents a native pointer that becomes invalid afterremove()is called. The previous code set it tonullbut the type didn't reflect this, requiring a type cast hack (as any) to work around TypeScript.This fix: