Skip to content

fix: Use Bun.spawnSync instead of execSync for better performance and error handling #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuzipu wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix: Use Bun.spawnSync instead of execSync for better performance and error handling #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions package/bin/electrobun.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env node

const { execSync, spawn } = require('child_process');
const { spawn } = require('child_process');
const { existsSync, mkdirSync, unlinkSync, chmodSync, copyFileSync, createWriteStream } = require('fs');
const { join, dirname } = require('path');
const https = require('https');
Expand Down Expand Up @@ -98,7 +98,13 @@ async function ensureCliBinary() {
await downloadFile(tarballUrl, tarballPath);

// Extract using system tar (available on macOS, Linux, and Windows 10+)
execSync(`tar -xzf "${tarballPath}"`, { cwd: cacheDir, stdio: 'pipe' });
const result = Bun.spawnSync(['tar', '-xzf', tarballPath], {
cwd: cacheDir,
stdio: 'pipe'
});
if (!result.success) {
throw new Error(`Failed to extract tarball: ${result.stderr?.toString() || 'Unknown error'}`);
}

// Clean up tarball
unlinkSync(tarballPath);
Expand Down