Draft
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
915b6d3 to
f7a8070
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6775 +/- ##
==========================================
- Coverage 56.24% 56.22% -0.03%
==========================================
Files 1976 1977 +1
Lines 87523 87666 +143
Branches 7809 7832 +23
==========================================
+ Hits 49226 49286 +60
- Misses 36468 36545 +77
- Partials 1829 1835 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎟️ Tracking
📔 Objective
This PR introduces an Aspire AppHost project to manage the deployment and configuration of the Bitwarden services. Additionally, it incorporates a ServiceDefaults project to standardize common configurations like health checks and OpenTelemetry across services using conditional compilation.
Notes:
ServiceDefaultshave been downgraded to accommodate the requirement ofMicrosoft.Extensions.Configurationremaining at version 8.0 due to dependency conflicts in integration tests with projects dependent onIntegrationTestCommon. Once the version 9.0 issues are resolved, we should be able to update these. They include:📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes