[PM-31180] Proposal use oxfmt instead of prettier#706
Conversation
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 79.62% 79.76% +0.14%
==========================================
Files 293 299 +6
Lines 32780 33210 +430
==========================================
+ Hits 26102 26491 +389
- Misses 6678 6719 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
oxfmt also handles toml files. We can disable this if we want, but I think using this over cargo sort probably produces better result.
djsmith85
left a comment
There was a problem hiding this comment.
Changes are looking good. I'm looking forward to the speed-improvements.
- Replaces the usage of prettier
- Deletes the prettier-config files so no cmd/extension picks up any rules by accident
- Changes the githook to use oxfmt
- Changes to package.json and toml files are minimal
- Removes prettier from renovate and adds oxfmt
- Instructions on README.md updated
Are we planning on also replacing this on clients?
Then we should follow up with a PR there and also update the contributing-docs. As a potential replacement for the prettier vscode plugin: oxc 🤷 ?
|
@djsmith85 I replaced the prettier extension recommendation with oxc and configured formatter for applicable files in vscode. There actually is a PR up for clients |


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31180
📔 Objective
Speeds up formatting almost by a factor of 7.
Oxlint: 0.6s
Prettier: ~4.1s
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes