[PM-30551] Fix: Lint only *.ts and *.vue files#173
Open
stopflunky wants to merge 2 commits intobitwarden:mainfrom
Open
[PM-30551] Fix: Lint only *.ts and *.vue files#173stopflunky wants to merge 2 commits intobitwarden:mainfrom
stopflunky wants to merge 2 commits intobitwarden:mainfrom
Conversation
…om lint script patterns as they should not be linted according to project requirements. Only TypeScript and Vue files should be checked. Fixes bitwarden#135
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the lint script was unintentionally
checking
.jsfiles in addition to.tsand.vuefiles.Changes
lintscript in package.json to exclude*.jsfileslint:checkscript in package.json to exclude*.jsfilesTesting
yarn run lintsuccessfully - all files pass lintingyarn run dev- site builds and runs correctly on localhost:8080Fixes #135