Force LTR text direction for passwords and TOTP codes #6309
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds TextStyle extension to force left-to-right text direction with locale-aware alignment for sensitive alphanumeric content. This ensures passwords and TOTP codes read correctly in RTL locales while maintaining proper alignment. - Add TextStyle.withForcedLtr() extension in TypographyExtensions.kt - Refactor BitwardenPasswordField to use extension - Refactor VerificationCodeItem (app) to use extension - Refactor VaultVerificationCodeItem (authenticator) to use extension
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6309 +/- ##
=======================================
Coverage 85.50% 85.50%
=======================================
Files 763 763
Lines 54601 54623 +22
Branches 7855 7855
=======================================
+ Hits 46684 46706 +22
Misses 5189 5189
Partials 2728 2728 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @OmitFromCoverage | ||
| @Composable | ||
| fun TextStyle.withForcedLtr(): TextStyle { | ||
| val layoutDirection = LocalLayoutDirection.current |
Collaborator
There was a problem hiding this comment.
Can we pass this in?
fun TextStyle.withForcedLtr(
layoutDirection: LayoutDirection = LocalLayoutDirection.current,
): TextStyle {| textDirection = TextDirection.Ltr, | ||
| textAlign = when (layoutDirection) { | ||
| LayoutDirection.Rtl -> TextAlign.End | ||
| LayoutDirection.Ltr -> TextAlign.Start |
Collaborator
There was a problem hiding this comment.
Does it make more sense to explicitly call out Left and Right instead End and Start?
Contributor
Author
There was a problem hiding this comment.
Yea, that's a little more concise. I'm for it.
| * - Password fields that should read "Pass123!" not "!321ssaP" in RTL locales | ||
| * - TOTP verification codes that should read "123 456" not "654 321" | ||
| * - Any alphanumeric content requiring LTR reading with locale-aware positioning | ||
| * |
| */ | ||
| @OmitFromCoverage | ||
| @Composable | ||
| fun TextStyle.withForcedLtr(): TextStyle { |
Collaborator
There was a problem hiding this comment.
What do you think about adding the word Direction in here? Like withForcedLtrDirection()?
- Rename extension to be more descriptive. - Use `Left` and `Right` text alignments instead of `Start` and `End`.
david-livefront
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-20026
Relates to #4753
📔 Objective
Fixes text direction and alignment issues for passwords and TOTP verification codes in RTL (right-to-left) locales such as Persian and Hebrew.
When the system locale is set to an RTL language, passwords and TOTP codes were displaying incorrectly—reading right-to-left instead of left-to-right, and aligning to the wrong side of the field.
This PR introduces a reusable
TextStyle.withForcedLtr()extension that forces left-to-right text direction while maintaining locale-aware alignment, ensuring alphanumeric credentials display correctly across all locales.Based on work started by @codokie in #5012
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes