DEPS: Update Jest#2579
Draft
catloversg wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Got it. I will ignore this for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Jest and its related deps to v30, which is the latest major version. Jest v29 is fairly old, and its deps have to use other outdated deps. For example, jest-environment-jsdom v29 depends on jsdom v20, which is why many of its deps end up being overridden.
While testing this PR, I encountered multiple issues caused by babel-plugin-transform-barrels. This plugin was added a long time ago to improve Jest test performance. However, in #2246, I noticed that after upgrading Jest-related dependencies, some tests failed on GitHub CI while still passing on my machine. After more testing now, I found even more issues.
I tested many combinations of environments (my machines and GitHub CI), babel-plugin-transform-barrels versions, and patches (both in Bitburner and babel-plugin-transform-barrels). Unfortunately, I did not document every combination, as I did not expect the situation to become this complex. Below are some notable cases I recorded:
Log [1]:
Log [2]:
IIRC, [2] is the same issue I encountered in #2246.
At this point, I'm fairly sure that there are bugs in babel-plugin-transform-barrels. However, removing the plugin causes Jest tests to run much slower (x2 time on my machines), which is why I mark this PR as a draft one.
Going forward, if we need to upgrade Jest urgently for any reason, we can merge this PR and accept the slower test performance. Otherwise, we can continue using the current Jest version and wait until the issues in babel-plugin-transform-barrels are resolved.