Skip to content

Update to xclim 0.61, xsdba 0.6.1 and xscen 0.15#537

Merged
aulemahal merged 16 commits into
mainfrom
upd-xclim-61
May 26, 2026
Merged

Update to xclim 0.61, xsdba 0.6.1 and xscen 0.15#537
aulemahal merged 16 commits into
mainfrom
upd-xclim-61

Conversation

@aulemahal

@aulemahal aulemahal commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Overview

This PR:

Changes:

  • Unpins a lot of things
  • Fixes a few issues to work with xclim 0.61
  • Last commit fixes around 600 warnings, for future-proofing and log readability.

Related Issue / Discussion

@fmigneault Could you check my changes about sentry ? This was for a warning about deprecated changes.

Additional Information

If there are breaking changes, they should be related to the xclim changes, I don't think I introduced anything new ;).

@Zeitsperre Zeitsperre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be making a few breaking changes here, seeing as we're jumping several versions in xclim and xscen.

Comment thread src/finch/processes/__init__.py Outdated
Comment thread src/finch/processes/wpsio.py Outdated
Comment thread environment.yml
Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Comment thread environment-docs.yml Outdated
Comment thread environment-docs.yml Outdated
Comment thread pyproject.toml Outdated
Comment thread environment.yml Outdated
@github-actions github-actions Bot added the docs Improvements to documenation label May 21, 2026
@github-actions github-actions Bot added the CI Continuous Integration label May 21, 2026
@aulemahal

Copy link
Copy Markdown
Collaborator Author

@Zeitsperre haha I had some trouble with the CI...

Installing in hybrid : conda env + dev deps in pip was giving broken envs after my unpins. I rationalized it a bit like we do elsewhere : one single env file installing normal deps as well as dev and docs deps.
I removed the develop and install entries of the Makefile to reflect this change of philosophy.

For ReadTheDocs, we had a custom funky setup that was created to avoid running out of memory on the remote build. This problem seems gone, here I simply install the full normal env and don't do any mockups.

@aulemahal

Copy link
Copy Markdown
Collaborator Author

Ach, I just saw that this change the Docker image by installing all unneeded dev tools in it... May be we could use pip in the docker image ? Or maybe it's not a problem.

@Zeitsperre

Copy link
Copy Markdown
Member

I'll give this a proper once-over next week!

@Zeitsperre Zeitsperre self-requested a review May 22, 2026 20:13
Comment thread Makefile
Comment thread pyproject.toml
Comment thread environment.yml
Comment thread environment-docs.yml
Comment thread docs/source/dev_guide.rst

@fmigneault fmigneault left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the docs dependencies will be re-added in a subsequent PR, that looks fine.

@aulemahal

Copy link
Copy Markdown
Collaborator Author

@fmigneault , not sure I understand, aren't the docs dependencies already here :

finch/pyproject.toml

Lines 94 to 105 in 180d9d2

docs = [
"alabaster >=1.0.0",
"birdhouse-birdy>=0.8.1",
"cf-xarray>=0.9.3",
"cftime>=1.4.1",
"ipython>=8.5.0",
"jupyter_client",
"matplotlib>=3.5.0",
"nbsphinx>=0.9.8",
"sphinx>=9.0.0",
"sphinxcontrib-bibtex>=2.6.0"
]
?

Also, on my VM, the compressed docker image is 1600 MB, which is more than the current 900 MB, for you information.

@fmigneault

Copy link
Copy Markdown
Member

@aulemahal
My bad. I didn’t notice that commit. You can ignore my comment. All good.

@Zeitsperre Zeitsperre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. There are more than a few things that need to be updated, but I'll get to them in the template.

If there isn't any urgency, we can merge this, perform additional updates and release on PyPI. Most importantly, the docker image needs to build properly if we want to use it with PAVICS.

Comment thread .github/workflows/main.yml Outdated
Comment thread .github/workflows/main.yml Outdated
Comment thread docs/source/installation.rst Outdated
Comment thread docs/source/installation.rst Outdated
Comment thread src/finch/cli.py Outdated
Comment thread .readthedocs.yml
Comment thread environment.yml Outdated
Comment thread environment.yml Outdated
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre

Copy link
Copy Markdown
Member

We're running into issues because of pytest-notebooks, which is quite out of date. We replaced this with nbval (although this library is very quickly becoming out of date as well).

@aulemahal

Copy link
Copy Markdown
Collaborator Author

Lol I think pytest-notebook is already unneeded, but was not removed from the env. Simple fix!

…I - no need to print env twice - make commands more explicit
aulemahal and others added 2 commits May 26, 2026 13:21
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@aulemahal aulemahal enabled auto-merge May 26, 2026 18:53
@aulemahal aulemahal merged commit f89a2d4 into main May 26, 2026
14 checks passed
@aulemahal aulemahal deleted the upd-xclim-61 branch May 26, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration docs Improvements to documenation

Projects

None yet

3 participants