Update to xclim 0.61, xsdba 0.6.1 and xscen 0.15#537
Conversation
Zeitsperre
left a comment
There was a problem hiding this comment.
I think we should be making a few breaking changes here, seeing as we're jumping several versions in xclim and xscen.
|
@Zeitsperre haha I had some trouble with the CI... Installing in hybrid : conda env + dev deps in pip was giving broken envs after my unpins. I rationalized it a bit like we do elsewhere : one single env file installing normal deps as well as dev and docs deps. For ReadTheDocs, we had a custom funky setup that was created to avoid running out of memory on the remote build. This problem seems gone, here I simply install the full normal env and don't do any mockups. |
|
Ach, I just saw that this change the Docker image by installing all unneeded dev tools in it... May be we could use pip in the docker image ? Or maybe it's not a problem. |
|
I'll give this a proper once-over next week! |
fmigneault
left a comment
There was a problem hiding this comment.
Assuming the docs dependencies will be re-added in a subsequent PR, that looks fine.
|
@fmigneault , not sure I understand, aren't the docs dependencies already here : Lines 94 to 105 in 180d9d2 Also, on my VM, the compressed docker image is 1600 MB, which is more than the current 900 MB, for you information. |
|
@aulemahal |
Zeitsperre
left a comment
There was a problem hiding this comment.
Looks pretty good. There are more than a few things that need to be updated, but I'll get to them in the template.
If there isn't any urgency, we can merge this, perform additional updates and release on PyPI. Most importantly, the docker image needs to build properly if we want to use it with PAVICS.
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
|
We're running into issues because of |
|
Lol I think |
…I - no need to print env twice - make commands more explicit
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Overview
This PR:
heat_wave_max_length/heat_wave_total_lengthprocesses in GetCapabilities birdhouse-deploy#657Changes:
Related Issue / Discussion
@fmigneault Could you check my changes about sentry ? This was for a warning about deprecated changes.
Additional Information
If there are breaking changes, they should be related to the xclim changes, I don't think I introduced anything new ;).