BIOP02-53 Critic 교차리뷰 (kkkim→sjpark): CLAM MIL — caution#21
Open
kakyungkim wants to merge 3 commits into
Open
Conversation
- 7-point: leakage PASS(site-disjoint 실검증), baseline PASS(subtype_only=PAM50 ceiling), cross-dataset CAUTION(HER2 외부 near-random), DRP/claim PASS - ER/PR 외부(CPTAC) 유지, HER2 실패. subtype_only 오판정 방지(ceiling≠floor) - critic_report.json(schema v0.1 valid) + REVIEW.md - 최종 pass는 braveji 총괄; CPTAC 라벨 self-reference로 #done 보류
재사용 스캐폴드(Ka-Kyung Kim, CC BY 4.0)를 팀 공유로 설치.
- .claude/agents/ 9개(재사용 7 + 도메인 슬롯 spatialpatho-analyst + manuscript-writer), 오케스트레이터 Skill, docs/HARNESS.md, CLAUDE.md 라우팅
- 도메인 슬롯 = 기존 agents/{data,embedding,modeling,therapeutic_evidence,critic} 파이프라인 대표
- .gitignore: !.claude/agents,skills 네가션 추가로 하네스만 팀 공유(settings.local.json은 개인별 유지)
- 분석 진행 단계 → 집필-단계 FILL(결과요약·verify-gate·headline·저자순서·GPU제공처 Modulabs)은 팀 확정 대기
Collaborator
Author
|
@braveji18 최종 sign-off 요청드립니다 🙏 이 PR은 BIOP02-53 Critic 교차리뷰(reviewer=kkkim → owner=sjpark, CLAM-SB attention MIL) 산출물입니다. 규정상 최종 verdict = caution — 7-point 요약:
주의: CPTAC 라벨은 kkkim 임시본(공개 cBioPortal 395/653)이라, self-reference 회피 위해 #done 전환 안 했습니다. jamie 공식 라벨(BIOP02-88 블록) 도착 시 외부평가 재실행 필요. 산출물: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critic 교차리뷰 — BIOP02-53 Attention MIL (owner: sjpark, reviewer: kkkim)
CLAM-SB attention MIL (UNI, ER/PR/HER2, TCGA→CPTAC) 실학습 결과에 대한 7-point 교차리뷰. verdict:
caution(모델링 cross-review까지; 최종 pass는 braveji 총괄).7-point
필수 후속
산출
experiments/kkkim/20260703_critic_biop02-53/critic_report.json(schema v0.1 valid)REVIEW.md🤖 Generated with Claude Code