Merged
Conversation
ilia-kats
force-pushed
the
likelihoods_dynamic_api
branch
from
b711115 to
0844312
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
==========================================
+ Coverage 90.18% 90.22% +0.04%
==========================================
Files 56 56
Lines 5735 5771 +36
==========================================
+ Hits 5172 5207 +35
- Misses 563 564 +1
🚀 New features to boost your workflow:
|
ilia-kats
force-pushed
the
likelihoods_dynamic_api
branch
2 times, most recently
from
4ee3010 to
8bc643a
Compare
ilia-kats
force-pushed
the
likelihoods_dynamic_api
branch
from
97210ff to
e442b6f
Compare
florinwalter
approved these changes
Apr 21, 2026
Collaborator
florinwalter
left a comment
florinwalter
left a comment
There was a problem hiding this comment.
Looks very good and dynamic
arberqoku
approved these changes
Apr 21, 2026
| self._wrapped = wrapped | ||
| self._forward = forward | ||
|
|
||
| def __dir__(self, forward: bool | None = None): |
Collaborator
There was a problem hiding this comment.
Suggestion to improve readability:
def __dir__(self, forward: bool | None = None):
should_forward = self._forward if forward is None else forward
names = list(self._wrapped.api())
if should_forward:
names.extend(self._model.__dir__())
return sorted(set(names))Also should we rather return a (unique) list instead, more explicit.
Collaborator
Author
There was a problem hiding this comment.
sorting and conversion to list are performed automatically when __dir__ is called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not really necessary currently, but may become necessary in the future (see e.g. the discussion in #145) and implementing it now avoids having to do another API break in the future.