Skip to content

fix: handle models without coefficients file in doc generator#197

Merged
marcbal77 merged 1 commit intobio-learn:masterfrom
marcbal77:fix/doc-generator-missing-file-key
Mar 25, 2026
Merged

fix: handle models without coefficients file in doc generator#197
marcbal77 merged 1 commit intobio-learn:masterfrom
marcbal77:fix/doc-generator-missing-file-key

Conversation

@marcbal77
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@sarudak sarudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement but a potential better solution would be to use the get methylation sties function to provide which sites are used as a backup. Something to consider for the future. This could be a good first issue

@marcbal77
Copy link
Copy Markdown
Member Author

Good call — created #200 to track this. The current fix handles the build failure, and methylation_sites() is the right long-term approach. Will need some rework in the generator since it operates on static definitions rather than instantiated models.

@marcbal77 marcbal77 merged commit a2ae519 into bio-learn:master Mar 25, 2026
1 check passed
@marcbal77 marcbal77 deleted the fix/doc-generator-missing-file-key branch March 25, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants