Open
Conversation
Owner
Author
|
Would love some input from @nikoksr and @ccoVeille |
ccoVeille
reviewed
Jan 17, 2025
Comment on lines
+44
to
+46
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.21' | ||
| go-version: '1.23' |
There was a problem hiding this comment.
You can remove the with here, it will use the last stable, it's enough for goreleaser I think, and so no need to maintain the latest go version here.
Another solution is to use 'go.mod' as a value here, please double check by reading the documentation of the GitHub action
Comment on lines
-49
to
-52
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| version: latest |
There was a problem hiding this comment.
Why removing golangci-lint from the CI?
|
|
||
| release: | ||
| name: Release | ||
| needs: [test, lint] |
There was a problem hiding this comment.
If you needs "lint", but you remove it, you will have an issue
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic to use performance enhancing solutions