Open
Conversation
The HTML specification requires the character encoding to be specified in the first 1024 bytes of the document, so it is best to place it as early as possible. https://html.spec.whatwg.org/multipage/semantics.html#charset
Twitter will reuse the matching Open Graph tags, and actually doesn't have a URL tag of its own, so it's best to omit them and save bandwidth. The card property is useful however, and is used by services other than Twitter, so it can be left there. To avoid confusion, I renamed the Open Graph header to Embed Tags.
There was an extra level of indentation for the head compared to every other page in the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some nitpicky things I noticed and was bored enough to fling a PR over. I justified them in the commit descriptions.
As a side note, typical convention across the web is to place the viewport declaration directly below the charset. However, I could not find any specification which says to do this, or any backwards compatibility reasons cited for doing so. It appears to be purely subjective, and many websites don't follow this convention. As such, I've left it alone.