Skip to content

#2 (fix): handle binary assets in /ak:commit skill#6

Open
bezael wants to merge 4 commits into
mainfrom
webinar
Open

#2 (fix): handle binary assets in /ak:commit skill#6
bezael wants to merge 4 commits into
mainfrom
webinar

Conversation

@bezael
Copy link
Copy Markdown
Owner

@bezael bezael commented Apr 29, 2026

Objective

The /ak:commit skill was failing or producing malformed commit messages when staged files included binary assets (images, fonts, compiled files). Without explicit handling, the model had no file names or semantic context when all staged content showed only as Binary files a/... and b/... differ.

Bug Fixes

  • Add git diff --staged --name-status to the skill context so binary file names and statuses are always available, even when diff content is absent
  • Add a rule instructing the model to use --name-status output to describe binary files and never omit them from the commit message
  • Apply the same fix to antigravity-skills/commit/SKILL.md for Google Antigravity / Gemini users
  • Recreate skills/commit/SKILL.md in the new frontmatter format (ak:commit, disable-model-invocation, allowed-tools) so the CLI installer can pick it up again

Tests

  • Add evals/fixtures/sample-diffs/chore-add-assets.diff — a realistic diff with two binary files (logo.png, inter.woff2) and a text change
  • Add a binary-assets test case to evals/skills/commit.eval.js with an extra rubric criterion verifying binary filenames are not silently dropped from the message
  • Extend runCommitEval to accept extraCriteria so individual test cases can inject additional rubric checks

Related

#2

bezael and others added 2 commits April 29, 2026 21:59
- Deleted obsolete skill documentation files for /commit, /debug, /memory, /plan, /pr, /review, and /vibe-audit to streamline the codebase and eliminate redundancy.
…ples

- Add "Getting started in 60 seconds" section at top of both READMEs
- Link each skill/agent name to its source file in the repo
- Add "Real output examples" section with collapsible blocks per skill

Closes #5

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment thread README.md

## Real output examples

<details>
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples are hidden behind collapsed blocks by default. Issue #5 states the problem as "new users have no visual reference and may not understand the value before trying it" — but a visitor skimming the page sees only five opaque <summary> labels unless they expand each one.

Consider showing at least the first example inline (the shortest one), and keeping the rest collapsed. Alternatively, link to a dedicated examples page to avoid cluttering the main README while still surfacing the content on first scan.

@bezael
Copy link
Copy Markdown
Owner Author

bezael commented Apr 29, 2026

Claude

Important

AI-generated review. This review was produced automatically by Claude Code (Anthropic). It may miss context or make mistakes — always apply your own judgment before acting on suggestions.


Pull request overview
This PR improves the README onboarding experience by adding a "Getting started in 60 seconds" section, linking each skill and agent to its source file, and providing collapsible real output examples for five skills. It also removes deprecated skills/*/SKILL.md files that were superseded by antigravity-skills/.

Changes:

  • Added quick-start section and output examples to README.md and README.es.md
  • Updated skill/agent tables with source file hyperlinks
  • Deleted 8 deprecated files under skills/

Caution

Two issues below will break the installer and CI. This PR should not merge until they are resolved.

CRITICAL — bin/cli.js installs zero skills after this PR merges

bin/cli.js hard-codes path.join(REPO_ROOT, 'skills') as the skill source on lines 235, 281, and 315. This PR deletes the entire skills/ directory. Running npx ai-workflow-kit after merge will silently install zero skills — no error thrown, just an empty result. The actual skill files now live in antigravity-skills/, but the CLI is never updated to point there.

Fix: update bin/cli.js to source from antigravity-skills/ (and agents/ for agent skills).

CRITICAL — evals/cli/cli.test.js will fail entirely

The integration test suite (evals/cli/cli.test.js) asserts that all 7 skills including memory are installed with a SKILL.md file. After the skills/ deletion, all of these assertions fail. CI will be broken on merge.

HIGH — skills/memory/SKILL.md deleted with no replacement

skills/memory/SKILL.md is removed but there is no antigravity-skills/memory/ equivalent. CLAUDE.md still documents /ak:memory save|recall|clean as available commands, but after this PR no installer path delivers the memory skill to users. Either migrate the skill to antigravity-skills/memory/SKILL.md or explicitly remove it from CLAUDE.md.

HIGH — Manual installation instructions are broken

The "Or manually" block in both READMEs still contains cp skills/*.md ~/.claude/skills/. After this PR, skills/ is gone. Any user following the manual path gets a "no such file or directory" error. The correct source is now antigravity-skills/.

HIGH — Contributing guide points to a deleted directory

Both READMEs tell contributors: "Add your skill in skills/name.md following the existing pattern." That directory no longer exists. The guide should point to antigravity-skills/ and explain the SKILL.md file convention.

MEDIUM — Project structure tree in both READMEs is stale

The file tree block still shows the old skills/ layout (skills/commit.md, skills/pr.md, etc.). After merge, any reader following it to find skill definitions will get 404s on GitHub. The tree should be updated to show antigravity-skills/ as the canonical location.

MEDIUM — GIFs/screenshots not addressed

Issue #5's first checklist item is "Add a short GIF or screenshot per skill showing a real interaction." The PR adds text-only examples and does not mention deferring the visual media requirement. If this is intentional deferral, a note in the PR description (or a follow-up issue) would make that explicit.


Reviewed changes
Claude reviewed 4 out of 10 changed files in this pull request and generated 1 inline comment.

- If this code review was useful, please react with a thumbs up. Otherwise, react with a thumbs down.

@bezael bezael changed the title docs: add getting started section, source links, and real output examples #2 (fix): handle binary assets in /ak:commit skill Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant