Add --no-lineno Option to Omit Line Numbers#351
Open
DabeDotCom wants to merge 2 commits intobeyondgrep:devfrom
Open
Add --no-lineno Option to Omit Line Numbers#351DabeDotCom wants to merge 2 commits intobeyondgrep:devfrom
--no-lineno Option to Omit Line Numbers#351DabeDotCom wants to merge 2 commits intobeyondgrep:devfrom
Conversation
Squashed commit of the following: commit 1ffe7e4 Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 19:48:42 2021 -0500 Implement 'output-color' Changes (TDD "Green") commit bbf6ca1 Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 19:47:11 2021 -0500 Add Desired (TDD "Red") 'output-color' Test commit 1fe31ee Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 19:07:14 2021 -0500 Add Initial (Passing) `t/ack-output-color.t` Test NOTE: This serves to document *current* behavior
Squashed commit of the following: commit 9f8ef37 Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 20:26:10 2021 -0500 Make `--no-lineno` and `--column` Mutually Exclusive Turning line numbers off when you're showing "--column" output could lead to ambiguous results. commit 7a7736f Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 20:09:35 2021 -0500 Implement "--no-lineno" Functionality commit 1512fd0 Author: Dabrien 'Dabe' Murphy <dabe@parabon.com> Date: Fri Dec 3 20:07:20 2021 -0500 Add Initial "--no-lineno" Option NOTE: Not Yet Implemented
Contributor
|
It is not immediately obvious if this PR addresses the previously discussed issue #311 head-on, or is only approximately the same issue. |
Collaborator
|
There is a lot to discuss about this. I don't think it makes sense to have a Let's move this discussion over to the original ticket at #142. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no way to produce the same output as grep:
This PR fixes lets you: