Open
Conversation
* Now parses help instead of embedding fixed strings.x * Provides relevant specific option completion for --type, color* & file completion * Prevents opts after '--' * No longer completes non-existent commands with have
Collaborator
|
@starcraftman Does this PR need to get updated? Or should I merge it now as is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #554 that I raised a while ago. Best way to see changes is to test it out I think. Noticeable things:
One important note, I've retained the parsing of options from --help[-types]. I employ caching so that only first push has a delay. On my slow i3 I barely notice it. Bash unfortunately doesn't have persistent caching like zsh.
If users/others are bothered by the delay, I can modify it to use the fixed strings approach you had before.
I'll also post this to users ML, though doesn't seem to have huge traffic.