decoder: always return NANOCBOR_OK instead of bytes read#97
Open
mguetschow wants to merge 1 commit into
Open
Conversation
For now, number of bytes read are returned for all number-related functions, but not for containers, tags and strings. This is an API breaking change. However, we did not come up with a good reason why users of NanoCBOR would be interested in the number of bytes read, especially if they only get this information for part of the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, number of bytes read are returned for all number-related functions, but not for containers, tags and strings. This PR unifies the behavior across all user-facing functions.
This is an API breaking change. However, we did not come up with a good reason why users of NanoCBOR would be interested in the number of bytes read, especially if they only get this information for part of the API.
Follow-up of #90