adhere to Debian version comparison guidelines#1
Merged
benprew merged 7 commits intobenprew:masterfrom Jul 7, 2025
Merged
Conversation
Owner
|
@camilajenny can you include your test script as part of this PR? Having a test script that can be rerun later in case someone wants to change the code would be useful. You can create the test/ directory in the root and put the files there. See geary as an example: https://gitlab.gnome.org/GNOME/geary/-/tree/mainline Thanks |
Author
|
@benprew thank you for your suggestion. I added the ValaUnit to the subprojects and I created a unit test, and added the test script instructions to the unit test. It's easily extensible now, in case we need more unit tests. I did it like in geary, and ValaUnit is LGPL so we can use and modify it here without any problem. I also fixed the upgrade / downgrade flag which I broke in previous commits. Please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see my comments on donadigo#140
and my tests https://gist.github.com/camilajenny/2059145ad34e4e5c3adbff47ccca7657
and it adheres to the official guidelines https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
Please review.