Open
Conversation
Open
|
Wow, need this ! |
|
👍 |
1 similar comment
|
👍 |
|
👍 |
|
👍 |
|
@JeremyFagis this isn't enough - is it? We'd need to do something like require('sprint.js');
window.$('#beep-boop');but if we added a commonjs-wrapper (#3) we'd do var $ = require('sprint.js'); |
|
A better approach would be to use a build system like gulp, who could automize the js minification, and the browser/amd/commonjs module wrapping(via gulp-umd, for instance). |
|
@philplckthun if you prefer to wrap and minify manually each time you modify a single line of code, why not :) |
|
@nervo Well, I was not saying that I prefer to minify manually! I said it doesn't make sense to use gulp-umd as long as gulp is not implemented at all. And that should be done with a full modularization of sprint in a seperate branch. 😉 |
|
@philplckthun 'got it :) |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Prepared npm package.