Skip to content

MTN set get_next as a regular method #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Badr-MOUFAD wants to merge 2 commits into
base: main
Choose a base branch
from
Open

MTN set get_next as a regular method #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a0181
fix get_next
Badr-MOUFAD Jun 28, 2023
1fdf0f6
revert unrelated changes
Badr-MOUFAD Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solvers/lasso_jl.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ function solve_lasso(
end

return w
end
end
3 changes: 1 addition & 2 deletions solvers/skglm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ def run(self, n_iter):
intercept = self.y_offset - self.X_offset @ self.coefs
self.coefs = np.vstack((self.coefs, intercept))

@staticmethod
def get_next(previous):
def get_next(self, previous):
return previous + 1

def get_result(self):
Expand Down