Skip to content

🎨 Palette: Add accessibility attributes and focus rings to Navbar #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belpythons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Add accessibility attributes and focus rings to Navbar #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-06 - Interactive Element Accessibility in Global Navigation
**Learning:** Disclosure widgets (like mobile menus and dropdowns) in global navigation often lack `aria-expanded` attributes, making their state opaque to screen readers. Additionally, icon-only buttons frequently lack explicit focus rings, rendering them inaccessible to keyboard users.
**Action:** Always include `aria-expanded` on any interactive disclosure widget and ensure explicit `focus-visible` styles (e.g., `focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500`) are applied to all interactive elements, particularly icon-only buttons.
15 changes: 10 additions & 5 deletions src/components/layout/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ const Navbar = () => {
<div className="relative" ref={dropdownRef}>
<button
onClick={toggleDropdown}
className={`flex items-center space-x-1 px-3 py-2 rounded-md text-sm font-medium transition-colors duration-200 ${location.pathname.startsWith('/forum')
aria-expanded={isDropdownOpen}
aria-haspopup="menu"
className={`flex items-center space-x-1 px-3 py-2 rounded-md text-sm font-medium transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500 ${location.pathname.startsWith('/forum')
? 'text-accent-500 bg-accent-50 dark:bg-navy-800'
: 'text-gray-700 dark:text-slate-300 hover:text-accent-500 hover:bg-gray-50 dark:hover:bg-navy-800'
}`}
Expand Down Expand Up @@ -139,7 +141,7 @@ const Navbar = () => {
{/* Theme Toggle Button */}
<button
onClick={toggleTheme}
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-all duration-300"
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-all duration-300 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500"
aria-label={isDark ? 'Switch to light mode' : 'Switch to dark mode'}
>
<FontAwesomeIcon
Expand All @@ -161,7 +163,7 @@ const Navbar = () => {
{/* Theme Toggle - Mobile */}
<button
onClick={toggleTheme}
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-colors duration-200"
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500"
aria-label={isDark ? 'Switch to light mode' : 'Switch to dark mode'}
>
<FontAwesomeIcon
Expand All @@ -172,15 +174,18 @@ const Navbar = () => {

<button
onClick={toggleMobile}
className="text-gray-700 dark:text-slate-300 hover:text-accent-500 p-2"
aria-expanded={isOpen}
aria-controls="mobile-menu"
aria-label="Toggle mobile menu"
className="text-gray-700 dark:text-slate-300 hover:text-accent-500 p-2 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500 rounded-lg"
>
<FontAwesomeIcon icon={isOpen ? faTimes : faBars} className="text-xl" />
</button>
</div>
</div>

{/* Mobile Navigation */}
<div className={`md:hidden transition-all duration-300 ease-in-out ${isOpen ? 'max-h-screen opacity-100' : 'max-h-0 opacity-0 overflow-hidden'}`}>
<div id="mobile-menu" className={`md:hidden transition-all duration-300 ease-in-out ${isOpen ? 'max-h-screen opacity-100' : 'max-h-0 opacity-0 overflow-hidden'}`}>
<div className="px-2 pt-2 pb-3 space-y-1 bg-white dark:bg-navy-900 border-t border-gray-200 dark:border-navy-700">
{navLinks.map((link) => (
<Link
Expand Down