Skip to content

🎨 Palette: Improve Navbar keyboard and screen reader accessibility #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belpythons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Improve Navbar keyboard and screen reader accessibility #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/components/layout/Navbar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,11 @@ const Navbar = () => {
<div className="relative" ref={dropdownRef}>
<button
onClick={toggleDropdown}
className={`flex items-center space-x-1 px-3 py-2 rounded-md text-sm font-medium transition-colors duration-200 ${location.pathname.startsWith('/forum')
className={`flex items-center space-x-1 px-3 py-2 rounded-md text-sm font-medium transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500 ${location.pathname.startsWith('/forum')
? 'text-accent-500 bg-accent-50 dark:bg-navy-800'
: 'text-gray-700 dark:text-slate-300 hover:text-accent-500 hover:bg-gray-50 dark:hover:bg-navy-800'
}`}
aria-expanded={isDropdownOpen}
>
<FontAwesomeIcon icon={faComments} className="text-sm" />
<span>Forum</span>
Expand Down Expand Up @@ -139,7 +140,7 @@ const Navbar = () => {
{/* Theme Toggle Button */}
<button
onClick={toggleTheme}
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-all duration-300"
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-all duration-300 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500"
aria-label={isDark ? 'Switch to light mode' : 'Switch to dark mode'}
>
<FontAwesomeIcon
Expand All @@ -161,7 +162,7 @@ const Navbar = () => {
{/* Theme Toggle - Mobile */}
<button
onClick={toggleTheme}
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-colors duration-200"
className="p-2 rounded-lg text-gray-600 dark:text-slate-300 hover:bg-gray-100 dark:hover:bg-navy-800 transition-colors duration-200 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500"
aria-label={isDark ? 'Switch to light mode' : 'Switch to dark mode'}
>
<FontAwesomeIcon
Expand All @@ -172,7 +173,9 @@ const Navbar = () => {

<button
onClick={toggleMobile}
className="text-gray-700 dark:text-slate-300 hover:text-accent-500 p-2"
className="text-gray-700 dark:text-slate-300 hover:text-accent-500 p-2 rounded-lg focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500"
aria-expanded={isOpen}
aria-label={isOpen ? "Close menu" : "Open menu"}
>
<FontAwesomeIcon icon={isOpen ? faTimes : faBars} className="text-xl" />
</button>
Expand Down