🎨 Palette: Add accessibility attributes and focus rings to Navbar#109
🎨 Palette: Add accessibility attributes and focus rings to Navbar#109belpythons wants to merge 1 commit into
Conversation
- Added aria-expanded to disclosure widgets (dropdown and mobile menu) - Added aria-haspopup to the forum dropdown - Added explicit focus-visible rings to icon-only buttons - Added dynamic aria-label to the mobile menu toggle Co-authored-by: belpythons <187399139+belpythons@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Added crucial ARIA attributes (
aria-expanded,aria-haspopup,aria-label) to disclosure widgets and icon-only interactive elements in the Navbar, along with explicit keyboard focus rings (focus-visible:ring-2).🎯 Why
Icon-only buttons and disclosure widgets (like dropdowns and mobile menus) lacked implicit state communication to screen readers and clear visual feedback for keyboard users navigating via Tab.
📸 Before/After
ring-accent-500outline upon keyboard focus, and screen readers will announce the expanded/collapsed state of menus.♿ Accessibility
aria-expandedandaria-haspopupto the Forum dropdown.aria-label(Open/Close menu) andaria-expandedto the mobile menu toggle button.focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent-500to all icon-only buttons for high-visibility keyboard navigation.PR created automatically by Jules for task 3976537212447928048 started by @belpythons