-
Notifications
You must be signed in to change notification settings - Fork 10
test of goalvc / add data initial stepper value #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
krugerk
wants to merge
7
commits into
beeminder:master
Choose a base branch
from
krugerk:bugfix/stepper-starts-with-wrong-value
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2993f47
test of goalvc / add data initial stepper value
krugerk 9f9f332
rather than feeding goalvc a goalvm
krugerk 00f8d11
migrating to goalVM
krugerk afa831d
some context on why PlusOne is the correct value
krugerk 2daaa2f
clean code
krugerk 96bd472
fastlane is not picking up swift-testing tests
krugerk 9b56b35
gather code coverage - enabled
krugerk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import Foundation | ||
|
|
||
| import CoreData | ||
| import BeeKit | ||
|
|
||
| struct GoalViewModel { | ||
| let goal: Goal | ||
|
|
||
| var title: String { | ||
| goal.slug | ||
| } | ||
|
|
||
| var isDataEntryHidden: Bool { | ||
| goal.hideDataEntry | ||
| } | ||
|
|
||
| var showPullToRefreshHint: Bool { | ||
| goal.isDataProvidedAutomatically | ||
| } | ||
|
|
||
| var pullToRefreshHint: String { | ||
| self.goal.isLinkedToHealthKit | ||
| ? "Pull down to synchronize with Apple Health" | ||
| : "Pull down to update" | ||
| } | ||
|
|
||
| var goalName: String { | ||
| goal.slug | ||
| } | ||
|
|
||
| var username: String { | ||
| goal.owner.username | ||
| } | ||
|
|
||
| var countdownLabelTextColor: UIColor? { | ||
| goal.countdownColor | ||
| } | ||
|
|
||
| var countdownLabelText: String? { | ||
| goal.capitalSafesum() | ||
| } | ||
|
|
||
| var suggestedNextValue: NSNumber { | ||
| goal.suggestedNextValue ?? 1 | ||
| } | ||
|
|
||
| var isHhmmFormat: Bool { | ||
| goal.hhmmFormat | ||
| } | ||
|
|
||
| var recentDatapoints: [DataPoint] { | ||
| goal.recentData.sorted(using: SortDescriptor(\.updatedAt)) | ||
| } | ||
|
|
||
| var isLinkedWithHealthKit: Bool { | ||
| goal.isLinkedToHealthKit | ||
| } | ||
|
|
||
| var usesManualDataEntry: Bool { | ||
| !goal.isDataProvidedAutomatically | ||
| } | ||
|
|
||
| var goalObjectId: NSManagedObjectID { | ||
| goal.objectID | ||
| } | ||
|
|
||
| var showTimerButton: Bool { | ||
| !goal.hideDataEntry | ||
| } | ||
|
|
||
| func initialDateStepperValue(submissionDate date: Date = Date()) -> Double { | ||
| let daystampAccountingForTheGoalsDeadline = Daystamp(fromDate: date, | ||
| deadline: goal.deadline) | ||
| let daystampAssumingMidnightDeadline = Daystamp(fromDate: date, | ||
| deadline: 0) | ||
|
|
||
| return Double(daystampAssumingMidnightDeadline.distance(to: daystampAccountingForTheGoalsDeadline)) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.