initial date in add datapoint started with tomorrow rather than yesterday#528
Merged
theospears merged 1 commit intobeeminder:masterfrom Nov 24, 2024
Conversation
Given the scenario, now is 1AM and one is entering into GoalVC for a goal with a deadline of 3AM the initial date shown was tomorrow. Expected might have been today and better yet is probably yesterday since 1AM is before the 3AM deadline, thus the daystamp for a datapoint added _now_ is still the (calendar) day before.
Contributor
Author
|
Fixes a bug introduced in #510. |
theospears
approved these changes
Nov 24, 2024
Collaborator
|
I've merged this, but could you open a follow up PR adding one or more regression tests around the date logic? |
Contributor
Author
draft here #529 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the scenario, now is 1AM and one is entering into GoalVC for a goal with a deadline of 3AM the initial date shown was tomorrow. Expected might have been today and better yet is probably yesterday since 1AM is before the 3AM deadline, thus the daystamp for a datapoint added now is still the (calendar) day before.
Fixes: #473