feat: add multi-stage Dockerfile and enhanced docker-compose deployment guide#12
Open
sakshar2303 wants to merge 1 commit intobeckfexx:mainfrom
Open
feat: add multi-stage Dockerfile and enhanced docker-compose deployment guide#12sakshar2303 wants to merge 1 commit intobeckfexx:mainfrom
sakshar2303 wants to merge 1 commit intobeckfexx:mainfrom
Conversation
Author
|
please review and merge . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #4 by providing a more robust and user-friendly Docker deployment setup for BrainDB.
Key Changes
Dockerfileto use a multi-stage approach. This reduces the final image size and improves security by running the application as a non-root user (bun).docker-compose.yml:.envfile.braindb_data) to ensure SQLite database persistence across container restarts.README.mdwith a detailed "Docker (recommended)" section that explains persistence, port mapping, and initial setup steps.Verification
docker-compose.ymlsyntax usingdocker compose config.Fixes #4